Skip to content

Commit

Permalink
[MTD] [NAND] fsl_elbc_nand: fix section mismatch between probe and re…
Browse files Browse the repository at this point in the history
…move

WARNING: drivers/mtd/nand/built-in.o(.devinit.text+0x114): Section mismatch
in reference from the function fsl_elbc_ctrl_probe() to the function
.devexit.text:fsl_elbc_ctrl_remove()

__devinit functions should not call functions with __devexit. Since probe
function calls remove in case of errors, we want to remove __devexit
attribute from it.

Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
Acked-by: Scott Wood <scottwood@freescale.com>
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
  • Loading branch information
Anton Vorontsov authored and David Woodhouse committed Jun 7, 2008
1 parent 4474573 commit aa83570
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/mtd/nand/fsl_elbc_nand.c
Original file line number Diff line number Diff line change
Expand Up @@ -917,7 +917,7 @@ static int __devinit fsl_elbc_ctrl_init(struct fsl_elbc_ctrl *ctrl)
return 0;
}

static int __devexit fsl_elbc_ctrl_remove(struct of_device *ofdev)
static int fsl_elbc_ctrl_remove(struct of_device *ofdev)
{
struct fsl_elbc_ctrl *ctrl = dev_get_drvdata(&ofdev->dev);
int i;
Expand Down Expand Up @@ -1041,7 +1041,7 @@ static struct of_platform_driver fsl_elbc_ctrl_driver = {
},
.match_table = fsl_elbc_match,
.probe = fsl_elbc_ctrl_probe,
.remove = __devexit_p(fsl_elbc_ctrl_remove),
.remove = fsl_elbc_ctrl_remove,
};

static int __init fsl_elbc_init(void)
Expand Down

0 comments on commit aa83570

Please sign in to comment.