Skip to content

Commit

Permalink
[SCSI] lpfc 8.3.7: Fix SCSI protocol related errors.
Browse files Browse the repository at this point in the history
Fix SCSI protocol related errors:
- Avoid I/O failures during EEH and HBA/CNA reset by correcting when
  we block the targets on the adapter.

Signed-off-by: James Smart <james.smart@emulex.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
  • Loading branch information
James Smart authored and James Bottomley committed Jan 4, 2010
1 parent def9c7a commit aacc20e
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
4 changes: 4 additions & 0 deletions drivers/scsi/lpfc/lpfc_hbadisc.c
Original file line number Diff line number Diff line change
Expand Up @@ -747,6 +747,10 @@ lpfc_linkdown(struct lpfc_hba *phba)

if (phba->link_state == LPFC_LINK_DOWN)
return 0;

/* Block all SCSI stack I/Os */
lpfc_scsi_dev_block(phba);

spin_lock_irq(&phba->hbalock);
phba->fcf.fcf_flag &= ~(FCF_AVAILABLE | FCF_DISCOVERED);
if (phba->link_state > LPFC_LINK_DOWN) {
Expand Down
5 changes: 3 additions & 2 deletions drivers/scsi/lpfc/lpfc_init.c
Original file line number Diff line number Diff line change
Expand Up @@ -7226,8 +7226,6 @@ lpfc_prep_dev_for_perm_failure(struct lpfc_hba *phba)
{
lpfc_printf_log(phba, KERN_ERR, LOG_INIT,
"2711 PCI channel permanent disable for failure\n");
/* Block all SCSI devices' I/Os on the host */
lpfc_scsi_dev_block(phba);
/* Clean up all driver's outstanding SCSI I/Os */
lpfc_sli_flush_fcp_rings(phba);
}
Expand Down Expand Up @@ -7256,6 +7254,9 @@ lpfc_io_error_detected_s3(struct pci_dev *pdev, pci_channel_state_t state)
struct Scsi_Host *shost = pci_get_drvdata(pdev);
struct lpfc_hba *phba = ((struct lpfc_vport *)shost->hostdata)->phba;

/* Block all SCSI devices' I/Os on the host */
lpfc_scsi_dev_block(phba);

switch (state) {
case pci_channel_io_normal:
/* Non-fatal error, prepare for recovery */
Expand Down

0 comments on commit aacc20e

Please sign in to comment.