Skip to content

Commit

Permalink
ath6kl: Remove unnecessary retrieval of first list entry in ath6kl_ht…
Browse files Browse the repository at this point in the history
…c_tx_setup_scat_list()

It is unnecessary to take the first list entry from queue again for
transmission. Sometimes it may look racy when the head of the list
changes between subsequent retrival, but should not happen in
practical.

Reported-by: Jouni Malinen <jouni@qca.qualcomm.com>
Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
  • Loading branch information
Vasanthakumar Thiagarajan authored and Kalle Valo committed Sep 27, 2011
1 parent 3038fac commit aad9339
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion drivers/net/wireless/ath/ath6kl/htc.c
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,6 @@ static int ath6kl_htc_tx_setup_scat_list(struct htc_target *target,

rem_scat -= len;
/* now remove it from the queue */
packet = list_first_entry(queue, struct htc_packet, list);
list_del(&packet->list);

scat_req->scat_list[i].packet = packet;
Expand Down

0 comments on commit aad9339

Please sign in to comment.