Skip to content

Commit

Permalink
cfq-iosched: remove cfq_io_context last_queue
Browse files Browse the repository at this point in the history
It hasn't been used for a while, kill it off and remove the old
if 0 code chunk.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
  • Loading branch information
Jens Axboe authored and Jens Axboe committed Feb 11, 2007
1 parent 783660b commit aaf1228
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 18 deletions.
19 changes: 2 additions & 17 deletions block/cfq-iosched.c
Original file line number Diff line number Diff line change
Expand Up @@ -1471,22 +1471,8 @@ cfq_get_io_context(struct cfq_data *cfqd, gfp_t gfp_mask)
static void
cfq_update_io_thinktime(struct cfq_data *cfqd, struct cfq_io_context *cic)
{
unsigned long elapsed, ttime;

/*
* if this context already has stuff queued, thinktime is from
* last queue not last end
*/
#if 0
if (time_after(cic->last_end_request, cic->last_queue))
elapsed = jiffies - cic->last_end_request;
else
elapsed = jiffies - cic->last_queue;
#else
elapsed = jiffies - cic->last_end_request;
#endif

ttime = min(elapsed, 2UL * cfqd->cfq_slice_idle);
unsigned long elapsed = jiffies - cic->last_end_request;
unsigned long ttime = min(elapsed, 2UL * cfqd->cfq_slice_idle);

cic->ttime_samples = (7*cic->ttime_samples + 256) / 8;
cic->ttime_total = (7*cic->ttime_total + 256*ttime) / 8;
Expand Down Expand Up @@ -1649,7 +1635,6 @@ cfq_rq_enqueued(struct cfq_data *cfqd, struct cfq_queue *cfqq,
cfq_update_io_seektime(cic, rq);
cfq_update_idle_window(cfqd, cfqq, cic);

cic->last_queue = jiffies;
cic->last_request_pos = rq->sector + rq->nr_sectors;

if (cfqq == cfqd->active_queue) {
Expand Down
1 change: 0 additions & 1 deletion include/linux/blkdev.h
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ struct cfq_io_context {

unsigned long last_end_request;
sector_t last_request_pos;
unsigned long last_queue;

unsigned long ttime_total;
unsigned long ttime_samples;
Expand Down

0 comments on commit aaf1228

Please sign in to comment.