Skip to content

Commit

Permalink
ACPI / PCI: Make pci_slot built-in only, not a module
Browse files Browse the repository at this point in the history
As discussed in thread at https://patchwork.kernel.org/patch/1946851/,
there's no value in supporting CONFIG_ACPI_PCI_SLOT=m any more.
So change Kconfig and code to only support building pci_slot as
built-in driver.

Signed-off-by: Jiang Liu <jiang.liu@huawei.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
  • Loading branch information
Jiang Liu authored and Bjorn Helgaas committed Feb 15, 2013
1 parent a276660 commit ab1a2e0
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 16 deletions.
5 changes: 1 addition & 4 deletions drivers/acpi/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ config ACPI_DEBUG_FUNC_TRACE
is about half of the penalty and is rarely useful.

config ACPI_PCI_SLOT
tristate "PCI slot detection driver"
bool "PCI slot detection driver"
depends on SYSFS
default n
help
Expand All @@ -317,9 +317,6 @@ config ACPI_PCI_SLOT
i.e., segment/bus/device/function tuples, with physical slots in
the system. If you are unsure, say N.

To compile this driver as a module, choose M here:
the module will be called pci_slot.

config X86_PM_TIMER
bool "Power Management Timer Support" if EXPERT
depends on X86
Expand Down
5 changes: 5 additions & 0 deletions drivers/acpi/internal.h
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,11 @@ struct acpi_ec {

extern struct acpi_ec *first_ec;

#ifdef CONFIG_ACPI_PCI_SLOT
void acpi_pci_slot_init(void);
#else
static inline void acpi_pci_slot_init(void) { }
#endif
int acpi_pci_root_init(void);
int acpi_ec_init(void);
int acpi_ec_ecdt_probe(void);
Expand Down
13 changes: 1 addition & 12 deletions drivers/acpi/pci_slot.c
Original file line number Diff line number Diff line change
Expand Up @@ -330,19 +330,8 @@ static struct dmi_system_id acpi_pci_slot_dmi_table[] __initdata = {
{}
};

static int __init
acpi_pci_slot_init(void)
void __init acpi_pci_slot_init(void)
{
dmi_check_system(acpi_pci_slot_dmi_table);
acpi_pci_register_driver(&acpi_pci_slot_driver);
return 0;
}

static void __exit
acpi_pci_slot_exit(void)
{
acpi_pci_unregister_driver(&acpi_pci_slot_driver);
}

module_init(acpi_pci_slot_init);
module_exit(acpi_pci_slot_exit);
1 change: 1 addition & 0 deletions drivers/acpi/scan.c
Original file line number Diff line number Diff line change
Expand Up @@ -1687,6 +1687,7 @@ int __init acpi_scan_init(void)

acpi_power_init();
acpi_pci_root_init();
acpi_pci_slot_init();

/*
* Enumerate devices in the ACPI namespace.
Expand Down

0 comments on commit ab1a2e0

Please sign in to comment.