Skip to content

Commit

Permalink
net: ppp_generic - use DEFINE_IDR for static initialization
Browse files Browse the repository at this point in the history
We could use DEFINE_IDR for statically allocated idr
that allow us to save a few lines of code.

And spell fix.

Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Cyrill Gorcunov authored and David S. Miller committed Dec 19, 2008
1 parent a109a5b commit ab5024a
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions drivers/net/ppp_generic.c
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ struct channel {
*/
static DEFINE_MUTEX(all_ppp_mutex);
static atomic_t ppp_unit_count = ATOMIC_INIT(0);
static struct idr ppp_units_idr;
static DEFINE_IDR(ppp_units_idr);

/*
* all_channels_lock protects all_channels and last_channel_index,
Expand Down Expand Up @@ -852,8 +852,6 @@ static int __init ppp_init(void)
"ppp");
}

idr_init(&ppp_units_idr);

out:
if (err)
printk(KERN_ERR "failed to register PPP device (%d)\n", err);
Expand Down Expand Up @@ -2435,7 +2433,7 @@ ppp_create_interface(int unit, int *retp)
if (unit_find(&ppp_units_idr, unit))
goto out2; /* unit already exists */
else {
/* darn, someone is cheatting us? */
/* darn, someone is cheating us? */
*retp = -EINVAL;
goto out2;
}
Expand Down

0 comments on commit ab5024a

Please sign in to comment.