Skip to content

Commit

Permalink
powerpc/pci: Remove pcibios_do_bus_setup()
Browse files Browse the repository at this point in the history
The function pcibios_do_bus_setup() was used by pcibios_fixup_bus()
to perform setup that is different between the 32-bit and 64-bit
code.  This difference no longer exists, thus the function is removed
and the setup now done directly from pci-common.c.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>
  • Loading branch information
Benjamin Herrenschmidt authored and Paul Mackerras committed Nov 5, 2008
1 parent 5328032 commit ab56ced
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 28 deletions.
1 change: 0 additions & 1 deletion arch/powerpc/include/asm/pci.h
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,6 @@ extern void pci_resource_to_user(const struct pci_dev *dev, int bar,
const struct resource *rsrc,
resource_size_t *start, resource_size_t *end);

extern void pcibios_do_bus_setup(struct pci_bus *bus);
extern void pcibios_fixup_of_probed_bus(struct pci_bus *bus);


Expand Down
16 changes: 11 additions & 5 deletions arch/powerpc/kernel/pci-common.c
Original file line number Diff line number Diff line change
Expand Up @@ -1076,18 +1076,24 @@ static void __devinit pcibios_fixup_bridge(struct pci_bus *bus)

static void __devinit __pcibios_fixup_bus(struct pci_bus *bus)
{
struct pci_dev *dev = bus->self;
struct pci_dev *dev;

pr_debug("PCI: Fixup bus %d (%s)\n", bus->number, dev ? pci_name(dev) : "PHB");
pr_debug("PCI: Fixup bus %d (%s)\n",
bus->number, bus->self ? pci_name(bus->self) : "PHB");

/* Fixup PCI<->PCI bridges. Host bridges are handled separately, for
* now differently between 32 and 64 bits.
*/
if (dev != NULL)
if (bus->self != NULL)
pcibios_fixup_bridge(bus);

/* Additional setup that is different between 32 and 64 bits for now */
pcibios_do_bus_setup(bus);
/* Setup bus DMA mappings */
if (ppc_md.pci_dma_bus_setup)
ppc_md.pci_dma_bus_setup(bus);

/* Setup DMA for all PCI devices on that bus */
list_for_each_entry(dev, &bus->devices, bus_list)
pcibios_setup_new_device(dev);

/* Platform specific bus fixups */
if (ppc_md.pcibios_fixup_bus)
Expand Down
11 changes: 0 additions & 11 deletions arch/powerpc/kernel/pci_32.c
Original file line number Diff line number Diff line change
Expand Up @@ -446,17 +446,6 @@ static int __init pcibios_init(void)

subsys_initcall(pcibios_init);

void __devinit pcibios_do_bus_setup(struct pci_bus *bus)
{
struct pci_dev *dev;

if (ppc_md.pci_dma_bus_setup)
ppc_md.pci_dma_bus_setup(bus);

list_for_each_entry(dev, &bus->devices, bus_list)
pcibios_setup_new_device(dev);
}

/* the next one is stolen from the alpha port... */
void __init
pcibios_update_irq(struct pci_dev *dev, int irq)
Expand Down
11 changes: 0 additions & 11 deletions arch/powerpc/kernel/pci_64.c
Original file line number Diff line number Diff line change
Expand Up @@ -507,17 +507,6 @@ int __devinit pcibios_map_io_space(struct pci_bus *bus)
}
EXPORT_SYMBOL_GPL(pcibios_map_io_space);

void __devinit pcibios_do_bus_setup(struct pci_bus *bus)
{
struct pci_dev *dev;

if (ppc_md.pci_dma_bus_setup)
ppc_md.pci_dma_bus_setup(bus);

list_for_each_entry(dev, &bus->devices, bus_list)
pcibios_setup_new_device(dev);
}

unsigned long pci_address_to_pio(phys_addr_t address)
{
struct pci_controller *hose, *tmp;
Expand Down

0 comments on commit ab56ced

Please sign in to comment.