Skip to content

Commit

Permalink
firewire: fw-ohci: missing dma_unmap_single
Browse files Browse the repository at this point in the history
at_context_queue_packet() didn't clean up in an early exit path.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Signed-off-by: Kristian Høgsberg <krh@redhat.com>
  • Loading branch information
Stefan Richter committed Oct 16, 2007
1 parent e524f61 commit ab88ca4
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/firewire/fw-ohci.c
Original file line number Diff line number Diff line change
Expand Up @@ -680,6 +680,9 @@ at_context_queue_packet(struct context *ctx, struct fw_packet *packet)

/* FIXME: Document how the locking works. */
if (ohci->generation != packet->generation) {
if (packet->payload_length > 0)
dma_unmap_single(ohci->card.device, payload_bus,
packet->payload_length, DMA_TO_DEVICE);
packet->ack = RCODE_GENERATION;
return -1;
}
Expand Down

0 comments on commit ab88ca4

Please sign in to comment.