Skip to content

Commit

Permalink
staging:iio:ad7298: Do not return error code in interrupt handler
Browse files Browse the repository at this point in the history
The interrupt handler should only ever return one of the three irqreturn_t
constants and not an error code. Also make sure to always call
iio_trigger_notify_done before leaving the trigger handler.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
  • Loading branch information
Lars-Peter Clausen authored and Jonathan Cameron committed Jul 8, 2012
1 parent 1764eff commit abad65c
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/staging/iio/adc/ad7298_ring.c
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ static irqreturn_t ad7298_trigger_handler(int irq, void *p)

b_sent = spi_sync(st->spi, &st->ring_msg);
if (b_sent)
return b_sent;
goto done;

if (indio_dev->scan_timestamp) {
time_ns = iio_get_time_ns();
Expand All @@ -95,6 +95,8 @@ static irqreturn_t ad7298_trigger_handler(int irq, void *p)
buf[i] = be16_to_cpu(st->rx_buf[i]);

indio_dev->buffer->access->store_to(ring, (u8 *)buf, time_ns);

done:
iio_trigger_notify_done(indio_dev->trig);

return IRQ_HANDLED;
Expand Down

0 comments on commit abad65c

Please sign in to comment.