Skip to content

Commit

Permalink
[MTD] DiskOnChip: Add some comments
Browse files Browse the repository at this point in the history
Add helpful comment about oobfree so I can't claim two years from 
now that I don't remember what I was thinking.

Signed-off-by: Dan Brown <dan_brown@ieee.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Dan Brown authored and Thomas Gleixner committed May 23, 2005
1 parent 7e4a1d3 commit abc37e6
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion drivers/mtd/nand/diskonchip.c
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
*
* Interface to generic NAND code for M-Systems DiskOnChip devices
*
* $Id: diskonchip.c,v 1.53 2005/04/07 13:39:13 dbrown Exp $
* $Id: diskonchip.c,v 1.54 2005/04/07 14:22:55 dbrown Exp $
*/

#include <linux/kernel.h>
Expand Down Expand Up @@ -1049,6 +1049,16 @@ static int doc200x_correct_data(struct mtd_info *mtd, u_char *dat, u_char *read_

//u_char mydatabuf[528];

/* The strange out-of-order .oobfree list below is a (possibly unneeded)
* attempt to retain compatibility. It used to read:
* .oobfree = { {8, 8} }
* Since that leaves two bytes unusable, it was changed. But the following
* scheme might affect existing jffs2 installs by moving the cleanmarker:
* .oobfree = { {6, 10} }
* jffs2 seems to handle the above gracefully, but the current scheme seems
* safer. The only problem with it is that any code that parses oobfree must
* be able to handle out-of-order segments.
*/
static struct nand_oobinfo doc200x_oobinfo = {
.useecc = MTD_NANDECC_AUTOPLACE,
.eccbytes = 6,
Expand Down

0 comments on commit abc37e6

Please sign in to comment.