Skip to content

Commit

Permalink
efi: Use early_mem*() instead of early_io*()
Browse files Browse the repository at this point in the history 
Use early_mem*() instead of early_io*() because all mapped EFI regions
are memory (usually RAM but they could also be ROM, EPROM, EEPROM, flash,
etc.) not I/O regions. Additionally, I/O family calls do not work correctly
under Xen in our case. early_ioremap() skips the PFN to MFN conversion
when building the PTE. Using it for memory will attempt to map the wrong
machine frame. However, all artificial EFI structures created under Xen
live in dom0 memory and should be mapped/unmapped using early_mem*() family
calls which map domain memory.

Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Mark Salter <msalter@redhat.com>
Signed-off-by: Matt Fleming <matt.fleming@intel.com>
  • Loading branch information
Daniel Kiper authored and Matt Fleming committed Jul 18, 2014
1 parent 4fa6248 commit abc93f8
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 16 deletions.
28 changes: 14 additions & 14 deletions arch/x86/platform/efi/efi.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,7 @@ void __init efi_unmap_memmap(void)
{
clear_bit(EFI_MEMMAP, &efi.flags);
if (memmap.map) {
early_iounmap(memmap.map, memmap.nr_map * memmap.desc_size);
early_memunmap(memmap.map, memmap.nr_map * memmap.desc_size);
memmap.map = NULL;
}
}
Expand All @@ -273,12 +273,12 @@ static int __init efi_systab_init(void *phys)
if (!data)
return -ENOMEM;
}
systab64 = early_ioremap((unsigned long)phys,
systab64 = early_memremap((unsigned long)phys,
sizeof(*systab64));
if (systab64 == NULL) {
pr_err("Couldn't map the system table!\n");
if (data)
early_iounmap(data, sizeof(*data));
early_memunmap(data, sizeof(*data));
return -ENOMEM;
}

Expand Down Expand Up @@ -310,9 +310,9 @@ static int __init efi_systab_init(void *phys)
systab64->tables;
tmp |= data ? data->tables : systab64->tables;

early_iounmap(systab64, sizeof(*systab64));
early_memunmap(systab64, sizeof(*systab64));
if (data)
early_iounmap(data, sizeof(*data));
early_memunmap(data, sizeof(*data));
#ifdef CONFIG_X86_32
if (tmp >> 32) {
pr_err("EFI data located above 4GB, disabling EFI.\n");
Expand All @@ -322,7 +322,7 @@ static int __init efi_systab_init(void *phys)
} else {
efi_system_table_32_t *systab32;

systab32 = early_ioremap((unsigned long)phys,
systab32 = early_memremap((unsigned long)phys,
sizeof(*systab32));
if (systab32 == NULL) {
pr_err("Couldn't map the system table!\n");
Expand All @@ -343,7 +343,7 @@ static int __init efi_systab_init(void *phys)
efi_systab.nr_tables = systab32->nr_tables;
efi_systab.tables = systab32->tables;

early_iounmap(systab32, sizeof(*systab32));
early_memunmap(systab32, sizeof(*systab32));
}

efi.systab = &efi_systab;
Expand All @@ -369,7 +369,7 @@ static int __init efi_runtime_init32(void)
{
efi_runtime_services_32_t *runtime;

runtime = early_ioremap((unsigned long)efi.systab->runtime,
runtime = early_memremap((unsigned long)efi.systab->runtime,
sizeof(efi_runtime_services_32_t));
if (!runtime) {
pr_err("Could not map the runtime service table!\n");
Expand All @@ -384,7 +384,7 @@ static int __init efi_runtime_init32(void)
efi_phys.set_virtual_address_map =
(efi_set_virtual_address_map_t *)
(unsigned long)runtime->set_virtual_address_map;
early_iounmap(runtime, sizeof(efi_runtime_services_32_t));
early_memunmap(runtime, sizeof(efi_runtime_services_32_t));

return 0;
}
Expand All @@ -393,7 +393,7 @@ static int __init efi_runtime_init64(void)
{
efi_runtime_services_64_t *runtime;

runtime = early_ioremap((unsigned long)efi.systab->runtime,
runtime = early_memremap((unsigned long)efi.systab->runtime,
sizeof(efi_runtime_services_64_t));
if (!runtime) {
pr_err("Could not map the runtime service table!\n");
Expand All @@ -408,7 +408,7 @@ static int __init efi_runtime_init64(void)
efi_phys.set_virtual_address_map =
(efi_set_virtual_address_map_t *)
(unsigned long)runtime->set_virtual_address_map;
early_iounmap(runtime, sizeof(efi_runtime_services_64_t));
early_memunmap(runtime, sizeof(efi_runtime_services_64_t));

return 0;
}
Expand Down Expand Up @@ -439,7 +439,7 @@ static int __init efi_runtime_init(void)
static int __init efi_memmap_init(void)
{
/* Map the EFI memory map */
memmap.map = early_ioremap((unsigned long)memmap.phys_map,
memmap.map = early_memremap((unsigned long)memmap.phys_map,
memmap.nr_map * memmap.desc_size);
if (memmap.map == NULL) {
pr_err("Could not map the memory map!\n");
Expand Down Expand Up @@ -487,14 +487,14 @@ void __init efi_init(void)
/*
* Show what we know for posterity
*/
c16 = tmp = early_ioremap(efi.systab->fw_vendor, 2);
c16 = tmp = early_memremap(efi.systab->fw_vendor, 2);
if (c16) {
for (i = 0; i < sizeof(vendor) - 1 && *c16; ++i)
vendor[i] = *c16++;
vendor[i] = '\0';
} else
pr_err("Could not map the firmware vendor!\n");
early_iounmap(tmp, 2);
early_memunmap(tmp, 2);

pr_info("EFI v%u.%.02u by %s\n",
efi.systab->hdr.revision >> 16,
Expand Down
4 changes: 2 additions & 2 deletions drivers/firmware/efi/efi.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ int __init efi_config_init(efi_config_table_type_t *arch_tables)
if (table64 >> 32) {
pr_cont("\n");
pr_err("Table located above 4GB, disabling EFI.\n");
early_iounmap(config_tables,
early_memunmap(config_tables,
efi.systab->nr_tables * sz);
return -EINVAL;
}
Expand All @@ -314,7 +314,7 @@ int __init efi_config_init(efi_config_table_type_t *arch_tables)
tablep += sz;
}
pr_cont("\n");
early_iounmap(config_tables, efi.systab->nr_tables * sz);
early_memunmap(config_tables, efi.systab->nr_tables * sz);

set_bit(EFI_CONFIG_TABLES, &efi.flags);

Expand Down

0 comments on commit abc93f8

Please sign in to comment.