Skip to content

Commit

Permalink
IIO: industrialio-core: Checking NULL instead of IS_ERR for debugfs_c…
Browse files Browse the repository at this point in the history
…reate_dir()

If defined CONFIG_DEBUG_FS, debugfs_create_dir returns NULL on failure.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Axel Lin authored and Greg Kroah-Hartman committed May 8, 2012
1 parent 5a28c87 commit abd5a2f
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions drivers/iio/industrialio-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -227,15 +227,12 @@ static int iio_device_register_debugfs(struct iio_dev *indio_dev)
if (indio_dev->info->debugfs_reg_access == NULL)
return 0;

if (IS_ERR(iio_debugfs_dentry))
if (!iio_debugfs_dentry)
return 0;

indio_dev->debugfs_dentry =
debugfs_create_dir(dev_name(&indio_dev->dev),
iio_debugfs_dentry);
if (IS_ERR(indio_dev->debugfs_dentry))
return PTR_ERR(indio_dev->debugfs_dentry);

if (indio_dev->debugfs_dentry == NULL) {
dev_warn(indio_dev->dev.parent,
"Failed to create debugfs directory\n");
Expand Down

0 comments on commit abd5a2f

Please sign in to comment.