Skip to content

Commit

Permalink
tcp: don't backtrack to sacked skbs
Browse files Browse the repository at this point in the history
Backtracking to sacked skbs is a horrible performance killer
since the hint cannot be advanced successfully past them...
...And it's totally unnecessary too.

In theory this is 2.6.27..28 regression but I doubt anybody
can make .28 to have worse performance because of other TCP
improvements.

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Ilpo Järvinen authored and David S. Miller committed Mar 2, 2009
1 parent 79cb5de commit ac11ba7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/ipv4/tcp_output.c
Original file line number Diff line number Diff line change
Expand Up @@ -2065,7 +2065,7 @@ void tcp_xmit_retransmit_queue(struct sock *sk)
goto begin_fwd;

} else if (!(sacked & TCPCB_LOST)) {
if (hole == NULL && !(sacked & TCPCB_SACKED_RETRANS))
if (hole == NULL && !(sacked & (TCPCB_SACKED_RETRANS|TCPCB_SACKED_ACKED)))
hole = skb;
continue;

Expand Down

0 comments on commit ac11ba7

Please sign in to comment.