Skip to content

Commit

Permalink
[NET]: Fix kfifo_alloc() error check.
Browse files Browse the repository at this point in the history
The return value of kfifo_alloc() should be checked by IS_ERR().

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Akinobu Mita authored and David S. Miller committed Nov 25, 2006
1 parent 753eab7 commit ac16ca6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
2 changes: 2 additions & 0 deletions net/dccp/probe.c
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,8 @@ static __init int dccpprobe_init(void)
init_waitqueue_head(&dccpw.wait);
spin_lock_init(&dccpw.lock);
dccpw.fifo = kfifo_alloc(bufsize, GFP_KERNEL, &dccpw.lock);
if (IS_ERR(dccpw.fifo))
return PTR_ERR(dccpw.fifo);

if (!proc_net_fops_create(procname, S_IRUSR, &dccpprobe_fops))
goto err0;
Expand Down
2 changes: 2 additions & 0 deletions net/ipv4/tcp_probe.c
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,8 @@ static __init int tcpprobe_init(void)
init_waitqueue_head(&tcpw.wait);
spin_lock_init(&tcpw.lock);
tcpw.fifo = kfifo_alloc(bufsize, GFP_KERNEL, &tcpw.lock);
if (IS_ERR(tcpw.fifo))
return PTR_ERR(tcpw.fifo);

if (!proc_net_fops_create(procname, S_IRUSR, &tcpprobe_fops))
goto err0;
Expand Down

0 comments on commit ac16ca6

Please sign in to comment.