Skip to content

Commit

Permalink
dm log: ensure log bitmap fits on log device
Browse files Browse the repository at this point in the history
Check that the log bitmap will fit within the log device.

Signed-off-by: Milan Broz <mbroz@redhat.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
  • Loading branch information
Milan Broz authored and Alasdair G Kergon committed Jan 6, 2009
1 parent 2045e88 commit ac1f0ac
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions drivers/md/dm-log.c
Original file line number Diff line number Diff line change
Expand Up @@ -457,6 +457,14 @@ static int create_log_context(struct dm_dirty_log *log, struct dm_target *ti,
*/
buf_size = dm_round_up((LOG_OFFSET << SECTOR_SHIFT) +
bitset_size, ti->limits.hardsect_size);

if (buf_size > dev->bdev->bd_inode->i_size) {
DMWARN("log device %s too small: need %llu bytes",
dev->name, (unsigned long long)buf_size);
kfree(lc);
return -EINVAL;
}

lc->header_location.count = buf_size >> SECTOR_SHIFT;

lc->io_req.mem.type = DM_IO_VMA;
Expand Down

0 comments on commit ac1f0ac

Please sign in to comment.