Skip to content

Commit

Permalink
tty/hvc_iucv: remove redundant NULL check
Browse files Browse the repository at this point in the history
Make smatch happy and remove this warning:

drivers/tty/hvc/hvc_iucv.c:1320 hvc_iucv_init() info: redundant null check on
hvc_iucv_filter calling kfree()

Signed-off-by: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
  • Loading branch information
Hendrik Brueckner authored and Martin Schwidefsky committed Oct 28, 2013
1 parent c81a90c commit ac526f4
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/tty/hvc/hvc_iucv.c
Original file line number Diff line number Diff line change
Expand Up @@ -1354,8 +1354,7 @@ static int __init hvc_iucv_init(void)
mempool_destroy(hvc_iucv_mempool);
kmem_cache_destroy(hvc_iucv_buffer_cache);
out_error:
if (hvc_iucv_filter)
kfree(hvc_iucv_filter);
kfree(hvc_iucv_filter);
hvc_iucv_devices = 0; /* ensure that we do not provide any device */
return rc;
}
Expand Down

0 comments on commit ac526f4

Please sign in to comment.