Skip to content

Commit

Permalink
x86: remove ifdef CONFIG_GART_IOMMU in pci-dma.c
Browse files Browse the repository at this point in the history
Our way to handle gart_* functions for CONFIG_GART_IOMMU and
!CONFIG_GART_IOMMU cases is inconsistent.

We have some dummy gart_* functions in !CONFIG_GART_IOMMU case and
also use ifdef CONFIG_GART_IOMMU tricks in pci-dma.c to call some
gart_* functions in only CONFIG_GART_IOMMU case.

This patch removes ifdef CONFIG_GART_IOMMU in pci-dma.c and always use
dummy gart_* functions in iommu.h.

Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Acked-by: Muli Ben-Yehuda <muli@il.ibm.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
FUJITA Tomonori authored and Ingo Molnar committed Jul 11, 2008
1 parent 46a7fa2 commit ac7ded2
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 7 deletions.
6 changes: 0 additions & 6 deletions arch/x86/kernel/pci-dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,7 @@ void __init pci_iommu_alloc(void)
* The order of these functions is important for
* fall-back/fail-over reasons
*/
#ifdef CONFIG_GART_IOMMU
gart_iommu_hole_init();
#endif

#ifdef CONFIG_CALGARY_IOMMU
detect_calgary();
Expand Down Expand Up @@ -184,9 +182,7 @@ static __init int iommu_setup(char *p)
swiotlb = 1;
#endif

#ifdef CONFIG_GART_IOMMU
gart_parse_options(p);
#endif

#ifdef CONFIG_CALGARY_IOMMU
if (!strncmp(p, "calgary", 7))
Expand Down Expand Up @@ -508,9 +504,7 @@ static int __init pci_iommu_init(void)

amd_iommu_init();

#ifdef CONFIG_GART_IOMMU
gart_iommu_init();
#endif

no_iommu_init();
return 0;
Expand Down
10 changes: 9 additions & 1 deletion include/asm-x86/iommu.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,18 @@ extern void gart_iommu_hole_init(void);
static inline void early_gart_iommu_check(void)
{
}

static inline void gart_iommu_init(void)
{
}
static inline void gart_iommu_shutdown(void)
{
}
static inline void gart_parse_options(char *options)
{
}
static inline void gart_iommu_hole_init(void)
{
}
#endif

#endif

0 comments on commit ac7ded2

Please sign in to comment.