Skip to content

Commit

Permalink
dm delay: cleanup
Browse files Browse the repository at this point in the history
Use setup_timer().
Replace semaphore with mutex.

Signed-off-by: Alasdair G Kergon <agk@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Alasdair G Kergon authored and Linus Torvalds committed Jul 12, 2007
1 parent 028867a commit ac81864
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions drivers/md/dm-delay.c
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

struct delay_c {
struct timer_list delay_timer;
struct semaphore timer_lock;
struct mutex timer_lock;
struct work_struct flush_expired_bios;
struct list_head delayed_bios;
atomic_t may_delay;
Expand Down Expand Up @@ -58,12 +58,12 @@ static void handle_delayed_timer(unsigned long data)

static void queue_timeout(struct delay_c *dc, unsigned long expires)
{
down(&dc->timer_lock);
mutex_lock(&dc->timer_lock);

if (!timer_pending(&dc->delay_timer) || expires < dc->delay_timer.expires)
mod_timer(&dc->delay_timer, expires);

up(&dc->timer_lock);
mutex_unlock(&dc->timer_lock);
}

static void flush_bios(struct bio *bio)
Expand Down Expand Up @@ -193,13 +193,11 @@ static int delay_ctr(struct dm_target *ti, unsigned int argc, char **argv)
goto bad;
}

init_timer(&dc->delay_timer);
dc->delay_timer.function = handle_delayed_timer;
dc->delay_timer.data = (unsigned long)dc;
setup_timer(&dc->delay_timer, handle_delayed_timer, (unsigned long)dc);

INIT_WORK(&dc->flush_expired_bios, flush_expired_bios);
INIT_LIST_HEAD(&dc->delayed_bios);
init_MUTEX(&dc->timer_lock);
mutex_init(&dc->timer_lock);
atomic_set(&dc->may_delay, 1);

ti->private = dc;
Expand Down

0 comments on commit ac81864

Please sign in to comment.