Skip to content

Commit

Permalink
wl1251: convert 32-bit values to le32 before writing to the chip
Browse files Browse the repository at this point in the history
The 32-bit values were not converted before writing them to the chip.
Change the wl1251_read32() and wl1251_write32() so that they always
read and write le32 values and convert to and from the CPU endianess.

Signed-off-by: Luciano Coelho <coelho@ti.com>
  • Loading branch information
Luciano Coelho committed Feb 15, 2012
1 parent 059625e commit ac9e2d9
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
9 changes: 4 additions & 5 deletions drivers/net/wireless/wl1251/io.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,16 +36,15 @@

static inline u32 wl1251_read32(struct wl1251 *wl, int addr)
{
u32 response;

wl->if_ops->read(wl, addr, &response, sizeof(u32));
wl->if_ops->read(wl, addr, &wl->buffer_32, sizeof(wl->buffer_32));

return response;
return le32_to_cpu(wl->buffer_32);
}

static inline void wl1251_write32(struct wl1251 *wl, int addr, u32 val)
{
wl->if_ops->write(wl, addr, &val, sizeof(u32));
wl->buffer_32 = cpu_to_le32(val);
wl->if_ops->write(wl, addr, &wl->buffer_32, sizeof(wl->buffer_32));
}

static inline u32 wl1251_read_elp(struct wl1251 *wl, int addr)
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/wireless/wl1251/wl1251.h
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ struct wl1251 {
struct wl1251_stats stats;
struct wl1251_debugfs debugfs;

u32 buffer_32;
__le32 buffer_32;
u32 buffer_cmd;
u8 buffer_busyword[WL1251_BUSY_WORD_LEN];
struct wl1251_rx_descriptor *rx_descriptor;
Expand Down

0 comments on commit ac9e2d9

Please sign in to comment.