Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 2909
b: refs/heads/master
c: 040c928
h: refs/heads/master
i:
  2907: 359165c
v: v3
  • Loading branch information
Tejun Heo authored and Linus Torvalds committed Jun 23, 2005
1 parent d598b37 commit aca4866
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 6 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: f7d37d028dfba90b1b747f8ac685bf0959aeda8b
refs/heads/master: 040c928c47b591d1cd9977cd6431cae213528b45
18 changes: 13 additions & 5 deletions trunk/drivers/block/ll_rw_blk.c
Original file line number Diff line number Diff line change
Expand Up @@ -912,10 +912,15 @@ void blk_queue_end_tag(request_queue_t *q, struct request *rq)
BUG_ON(tag == -1);

if (unlikely(tag >= bqt->max_depth))
/*
* This can happen after tag depth has been reduced.
* FIXME: how about a warning or info message here?
*/
return;

if (unlikely(!__test_and_clear_bit(tag, bqt->tag_map))) {
printk("attempt to clear non-busy tag (%d)\n", tag);
printk(KERN_ERR "%s: attempt to clear non-busy tag (%d)\n",
__FUNCTION__, tag);
return;
}

Expand All @@ -924,7 +929,8 @@ void blk_queue_end_tag(request_queue_t *q, struct request *rq)
rq->tag = -1;

if (unlikely(bqt->tag_index[tag] == NULL))
printk("tag %d is missing\n", tag);
printk(KERN_ERR "%s: tag %d is missing\n",
__FUNCTION__, tag);

bqt->tag_index[tag] = NULL;
bqt->busy--;
Expand Down Expand Up @@ -957,8 +963,9 @@ int blk_queue_start_tag(request_queue_t *q, struct request *rq)

if (unlikely((rq->flags & REQ_QUEUED))) {
printk(KERN_ERR
"request %p for device [%s] already tagged %d",
rq, rq->rq_disk ? rq->rq_disk->disk_name : "?", rq->tag);
"%s: request %p for device [%s] already tagged %d",
__FUNCTION__, rq,
rq->rq_disk ? rq->rq_disk->disk_name : "?", rq->tag);
BUG();
}

Expand Down Expand Up @@ -1001,7 +1008,8 @@ void blk_queue_invalidate_tags(request_queue_t *q)
rq = list_entry_rq(tmp);

if (rq->tag == -1) {
printk("bad tag found on list\n");
printk(KERN_ERR
"%s: bad tag found on list\n", __FUNCTION__);
list_del_init(&rq->queuelist);
rq->flags &= ~REQ_QUEUED;
} else
Expand Down

0 comments on commit aca4866

Please sign in to comment.