Skip to content

Commit

Permalink
thermal: exynos: Remove check for thermal device pointer at exynos_re…
Browse files Browse the repository at this point in the history
…port_trigger()

The commit 4de0bda
("thermal: exynos: Add support for instance based register/unregister")
broke check for presence of therm_dev at global thermal zone in
exynos_report_trigger().

The resulting wrong test prevents thermal_zone_device_update() call, which
calls handlers for situation when trip points are passed.
Such behavior prevents thermal driver from proper reaction (when TMU interrupt
is raised) in a situation when overheating is detected at TMU hardware.

It turns out, that after exynos thermal subsystem redesign (at v3.12) this
check is not needed, since it is not possible to register thermal zone
without valid thermal device.

Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com>
  • Loading branch information
Lukasz Majewski authored and Eduardo Valentin committed Oct 15, 2013
1 parent 22356f4 commit acecdb3
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/thermal/samsung/exynos_thermal_common.c
Original file line number Diff line number Diff line change
Expand Up @@ -310,8 +310,6 @@ void exynos_report_trigger(struct thermal_sensor_conf *conf)
}

th_zone = conf->pzone_data;
if (th_zone->therm_dev)
return;

if (th_zone->bind == false) {
for (i = 0; i < th_zone->cool_dev_size; i++) {
Expand Down

0 comments on commit acecdb3

Please sign in to comment.