Skip to content

Commit

Permalink
x86: nmi_32/64.c - use apic_write_around instead of apic_write
Browse files Browse the repository at this point in the history
apic_write_around will be expanded to apic_write in 64bit mode
anyway. Only a few CPUs (well, old CPUs to be precise) requires
such an action. In general it should not hurt and could be cleaned
up for apic_write (just in case)

Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: hpa@zytor.com
Cc: mingo@redhat.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Cyrill Gorcunov authored and Thomas Gleixner committed May 25, 2008
1 parent 4b82b27 commit ad63ba1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion arch/x86/kernel/nmi_32.c
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ void acpi_nmi_enable(void)

static void __acpi_nmi_disable(void *__unused)
{
apic_write(APIC_LVT0, APIC_DM_NMI | APIC_LVT_MASKED);
apic_write_around(APIC_LVT0, APIC_DM_NMI | APIC_LVT_MASKED);
}

/*
Expand Down
4 changes: 2 additions & 2 deletions arch/x86/kernel/nmi_64.c
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ late_initcall(init_lapic_nmi_sysfs);

static void __acpi_nmi_enable(void *__unused)
{
apic_write(APIC_LVT0, APIC_DM_NMI);
apic_write_around(APIC_LVT0, APIC_DM_NMI);
}

/*
Expand All @@ -229,7 +229,7 @@ void acpi_nmi_enable(void)

static void __acpi_nmi_disable(void *__unused)
{
apic_write(APIC_LVT0, APIC_DM_NMI | APIC_LVT_MASKED);
apic_write_around(APIC_LVT0, APIC_DM_NMI | APIC_LVT_MASKED);
}

/*
Expand Down

0 comments on commit ad63ba1

Please sign in to comment.