Skip to content

Commit

Permalink
cifs: change && to ||
Browse files Browse the repository at this point in the history
This is a typo, if pvolume_info were NULL it would oops.

This function is used in clean up and error handling.  The current code
never passes a NULL pvolume_info, but it could pass a NULL *pvolume_info
if the kmalloc() failed.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>
  • Loading branch information
Dan Carpenter authored and Steve French committed Apr 26, 2010
1 parent 04912d6 commit ad6cca6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/cifs/connect.c
Original file line number Diff line number Diff line change
Expand Up @@ -2421,7 +2421,7 @@ cleanup_volume_info(struct smb_vol **pvolume_info)
{
struct smb_vol *volume_info;

if (!pvolume_info && !*pvolume_info)
if (!pvolume_info || !*pvolume_info)
return;

volume_info = *pvolume_info;
Expand Down

0 comments on commit ad6cca6

Please sign in to comment.