Skip to content

Commit

Permalink
[PATCH] x86_64: Initialize powernow_data[] for all siblings
Browse files Browse the repository at this point in the history
I got an oops on a dual core system because the lost tick handler
called cpufreq_get() on core 1 and powernow tried to follow
a NULL powernow_data[] pointer there.

Initialize powernow_data for all cores of a CPU.

Cc: Jacob Shin <jacob.shin@amd.com>
Cc: Dave Jones <davej@redhat.com>
Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Andi Kleen authored and Linus Torvalds committed Mar 25, 2006
1 parent 0085979 commit ad90573
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions arch/i386/kernel/cpu/cpufreq/powernow-k8.c
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ static DECLARE_MUTEX(fidvid_sem);
static struct powernow_k8_data *powernow_data[NR_CPUS];

#ifndef CONFIG_SMP
static cpumask_t cpu_core_map[1];
static cpumask_t cpu_core_map[1] = { CPU_MASK_ALL };
#endif

/* Return a frequency in MHz, given an input fid */
Expand Down Expand Up @@ -976,7 +976,7 @@ static int __cpuinit powernowk8_cpu_init(struct cpufreq_policy *pol)
{
struct powernow_k8_data *data;
cpumask_t oldmask = CPU_MASK_ALL;
int rc;
int rc, i;

if (!cpu_online(pol->cpu))
return -ENODEV;
Expand Down Expand Up @@ -1062,7 +1062,8 @@ static int __cpuinit powernowk8_cpu_init(struct cpufreq_policy *pol)
printk("cpu_init done, current fid 0x%x, vid 0x%x\n",
data->currfid, data->currvid);

powernow_data[pol->cpu] = data;
for_each_cpu_mask(i, cpu_core_map[pol->cpu])
powernow_data[i] = data;

return 0;

Expand Down

0 comments on commit ad90573

Please sign in to comment.