Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 352058
b: refs/heads/master
c: 38673c8
h: refs/heads/master
v: v3
  • Loading branch information
Joe Perches authored and David S. Miller committed Feb 4, 2013
1 parent 6842566 commit ade94d6
Show file tree
Hide file tree
Showing 7 changed files with 18 additions and 42 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: b2adaca92c63b9bb8beb021d554f656e387a7648
refs/heads/master: 38673c8218a6bcaac97b0243089e33617e28f43f
6 changes: 2 additions & 4 deletions trunk/drivers/net/usb/ax88172a.c
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ static int ax88172a_init_mdio(struct usbnet *dev)

priv->mdio->irq = kzalloc(sizeof(int) * PHY_MAX_ADDR, GFP_KERNEL);
if (!priv->mdio->irq) {
netdev_err(dev->net, "Could not allocate mdio->irq\n");
ret = -ENOMEM;
goto mfree;
}
Expand Down Expand Up @@ -236,10 +235,9 @@ static int ax88172a_bind(struct usbnet *dev, struct usb_interface *intf)
usbnet_get_endpoints(dev, intf);

priv = kzalloc(sizeof(*priv), GFP_KERNEL);
if (!priv) {
netdev_err(dev->net, "Could not allocate memory for private data\n");
if (!priv)
return -ENOMEM;
}

dev->driver_priv = priv;

/* Get the MAC address */
Expand Down
25 changes: 7 additions & 18 deletions trunk/drivers/net/usb/hso.c
Original file line number Diff line number Diff line change
Expand Up @@ -2317,10 +2317,8 @@ static int hso_serial_common_create(struct hso_serial *serial, int num_urbs,
serial->rx_urb[i]->transfer_buffer_length = 0;
serial->rx_data[i] = kzalloc(serial->rx_data_length,
GFP_KERNEL);
if (!serial->rx_data[i]) {
dev_err(dev, "%s - Out of memory\n", __func__);
if (!serial->rx_data[i])
goto exit;
}
}

/* TX, allocate urb and initialize */
Expand All @@ -2336,15 +2334,12 @@ static int hso_serial_common_create(struct hso_serial *serial, int num_urbs,
serial->tx_buffer_count = 0;
serial->tx_data_length = tx_size;
serial->tx_data = kzalloc(serial->tx_data_length, GFP_KERNEL);
if (!serial->tx_data) {
dev_err(dev, "%s - Out of memory\n", __func__);
if (!serial->tx_data)
goto exit;
}

serial->tx_buffer = kzalloc(serial->tx_data_length, GFP_KERNEL);
if (!serial->tx_buffer) {
dev_err(dev, "%s - Out of memory\n", __func__);
if (!serial->tx_buffer)
goto exit;
}

return 0;
exit:
Expand Down Expand Up @@ -2580,21 +2575,17 @@ static struct hso_device *hso_create_net_device(struct usb_interface *interface,
}
hso_net->mux_bulk_rx_buf_pool[i] = kzalloc(MUX_BULK_RX_BUF_SIZE,
GFP_KERNEL);
if (!hso_net->mux_bulk_rx_buf_pool[i]) {
dev_err(&interface->dev, "Could not allocate rx buf\n");
if (!hso_net->mux_bulk_rx_buf_pool[i])
goto exit;
}
}
hso_net->mux_bulk_tx_urb = usb_alloc_urb(0, GFP_KERNEL);
if (!hso_net->mux_bulk_tx_urb) {
dev_err(&interface->dev, "Could not allocate tx urb\n");
goto exit;
}
hso_net->mux_bulk_tx_buf = kzalloc(MUX_BULK_TX_BUF_SIZE, GFP_KERNEL);
if (!hso_net->mux_bulk_tx_buf) {
dev_err(&interface->dev, "Could not allocate tx buf\n");
if (!hso_net->mux_bulk_tx_buf)
goto exit;
}

add_net_device(hso_dev);

Expand Down Expand Up @@ -2818,10 +2809,8 @@ struct hso_shared_int *hso_create_shared_int(struct usb_interface *interface)
mux->shared_intr_buf =
kzalloc(le16_to_cpu(mux->intr_endp->wMaxPacketSize),
GFP_KERNEL);
if (!mux->shared_intr_buf) {
dev_err(&interface->dev, "Could not allocate intr buf?\n");
if (!mux->shared_intr_buf)
goto exit;
}

mutex_init(&mux->shared_int_lock);

Expand Down
10 changes: 3 additions & 7 deletions trunk/drivers/net/usb/sierra_net.c
Original file line number Diff line number Diff line change
Expand Up @@ -459,11 +459,9 @@ static void sierra_net_kevent(struct work_struct *work)

/* Query the modem for the LSI message */
buf = kzalloc(SIERRA_NET_USBCTL_BUF_LEN, GFP_KERNEL);
if (!buf) {
netdev_err(dev->net,
"failed to allocate buf for LS msg\n");
if (!buf)
return;
}

ifnum = priv->ifnum;
len = usb_control_msg(dev->udev, usb_rcvctrlpipe(dev->udev, 0),
USB_CDC_GET_ENCAPSULATED_RESPONSE,
Expand Down Expand Up @@ -686,10 +684,8 @@ static int sierra_net_bind(struct usbnet *dev, struct usb_interface *intf)
}
/* Initialize sierra private data */
priv = kzalloc(sizeof *priv, GFP_KERNEL);
if (!priv) {
dev_err(&dev->udev->dev, "No memory");
if (!priv)
return -ENOMEM;
}

priv->usbnet = dev;
priv->ifnum = ifacenum;
Expand Down
6 changes: 2 additions & 4 deletions trunk/drivers/net/usb/smsc75xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -1393,13 +1393,11 @@ static int smsc75xx_bind(struct usbnet *dev, struct usb_interface *intf)
}

dev->data[0] = (unsigned long)kzalloc(sizeof(struct smsc75xx_priv),
GFP_KERNEL);
GFP_KERNEL);

pdata = (struct smsc75xx_priv *)(dev->data[0]);
if (!pdata) {
netdev_warn(dev->net, "Unable to allocate smsc75xx_priv\n");
if (!pdata)
return -ENOMEM;
}

pdata->dev = dev;

Expand Down
6 changes: 2 additions & 4 deletions trunk/drivers/net/usb/smsc95xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -1116,13 +1116,11 @@ static int smsc95xx_bind(struct usbnet *dev, struct usb_interface *intf)
}

dev->data[0] = (unsigned long)kzalloc(sizeof(struct smsc95xx_priv),
GFP_KERNEL);
GFP_KERNEL);

pdata = (struct smsc95xx_priv *)(dev->data[0]);
if (!pdata) {
netdev_warn(dev->net, "Unable to allocate struct smsc95xx_priv\n");
if (!pdata)
return -ENOMEM;
}

spin_lock_init(&pdata->mac_cr_lock);

Expand Down
5 changes: 1 addition & 4 deletions trunk/drivers/net/usb/usbnet.c
Original file line number Diff line number Diff line change
Expand Up @@ -1790,11 +1790,8 @@ int usbnet_write_cmd_async(struct usbnet *dev, u8 cmd, u8 reqtype,
}

req = kmalloc(sizeof(struct usb_ctrlrequest), GFP_ATOMIC);
if (!req) {
netdev_err(dev->net, "Failed to allocate memory for %s\n",
__func__);
if (!req)
goto fail_free_buf;
}

req->bRequestType = reqtype;
req->bRequest = cmd;
Expand Down

0 comments on commit ade94d6

Please sign in to comment.