Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 297482
b: refs/heads/master
c: 7bec78e
h: refs/heads/master
v: v3
  • Loading branch information
Julia Lawall authored and Vinod Koul committed Jan 31, 2012
1 parent a8da014 commit adfe178
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 7 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 2b4f130e05cb28a9794921aad5139615e94a7b02
refs/heads/master: 7bec78e0a82418021dc2e63dea4d2b749953086d
17 changes: 11 additions & 6 deletions trunk/drivers/dma/pl330.c
Original file line number Diff line number Diff line change
Expand Up @@ -829,7 +829,7 @@ pl330_probe(struct amba_device *adev, const struct amba_id *id)
if (IS_ERR(pdmac->clk)) {
dev_err(&adev->dev, "Cannot get operation clock.\n");
ret = -EINVAL;
goto probe_err1;
goto probe_err2;
}

amba_set_drvdata(adev, pdmac);
Expand All @@ -843,11 +843,11 @@ pl330_probe(struct amba_device *adev, const struct amba_id *id)
ret = request_irq(irq, pl330_irq_handler, 0,
dev_name(&adev->dev), pi);
if (ret)
goto probe_err2;
goto probe_err3;

ret = pl330_add(pi);
if (ret)
goto probe_err3;
goto probe_err4;

INIT_LIST_HEAD(&pdmac->desc_pool);
spin_lock_init(&pdmac->pool_lock);
Expand Down Expand Up @@ -904,7 +904,7 @@ pl330_probe(struct amba_device *adev, const struct amba_id *id)
ret = dma_async_device_register(pd);
if (ret) {
dev_err(&adev->dev, "unable to register DMAC\n");
goto probe_err4;
goto probe_err5;
}

dev_info(&adev->dev,
Expand All @@ -917,10 +917,15 @@ pl330_probe(struct amba_device *adev, const struct amba_id *id)

return 0;

probe_err4:
probe_err5:
pl330_del(pi);
probe_err3:
probe_err4:
free_irq(irq, pi);
probe_err3:
#ifndef CONFIG_PM_RUNTIME
clk_disable(pdmac->clk);
#endif
clk_put(pdmac->clk);
probe_err2:
iounmap(pi->base);
probe_err1:
Expand Down

0 comments on commit adfe178

Please sign in to comment.