Skip to content

Commit

Permalink
[PATCH] kobject: quiet errors in kobject_add
Browse files Browse the repository at this point in the history
People don't like released kernels yelling at them, no matter how real the
error might be.  So only report it if CONFIG_KOBJECT_DEBUG is enabled.

Sent on request of Andrew Morton.

(akpm: should bring this back post-2.6.17)

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Greg Kroah-Hartman authored and Linus Torvalds committed May 21, 2006
1 parent b3969e5 commit ae57a85
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions lib/kobject.c
Original file line number Diff line number Diff line change
Expand Up @@ -198,14 +198,14 @@ int kobject_add(struct kobject * kobj)

/* be noisy on error issues */
if (error == -EEXIST)
printk("kobject_add failed for %s with -EEXIST, "
pr_debug("kobject_add failed for %s with -EEXIST, "
"don't try to register things with the "
"same name in the same directory.\n",
kobject_name(kobj));
else
printk("kobject_add failed for %s (%d)\n",
pr_debug("kobject_add failed for %s (%d)\n",
kobject_name(kobj), error);
dump_stack();
/* dump_stack(); */
}

return error;
Expand Down

0 comments on commit ae57a85

Please sign in to comment.