Skip to content

Commit

Permalink
regmap: mmio: convert some error returns to BUG()
Browse files Browse the repository at this point in the history
Some of the error conditions detected by regmap_mmio_*() are pure internal
errors, rather than user-/client-triggerable conditions. Convert these to
BUG().

Signed-off-by: Stephen Warren <swarren@nvidia.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
  • Loading branch information
Stephen Warren authored and Mark Brown committed Apr 13, 2012
1 parent ecb44ae commit ae5d8af
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions drivers/base/regmap/regmap-mmio.c
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ static int regmap_mmio_gather_write(void *context,
struct regmap_mmio_context *ctx = context;
u32 offset;

if (reg_size != 4)
return -EIO;
BUG_ON(reg_size != 4);

if (val_size % ctx->val_bytes)
return -EIO;

Expand All @@ -60,7 +60,7 @@ static int regmap_mmio_gather_write(void *context,
#endif
default:
/* Should be caught by regmap_mmio_check_config */
return -EIO;
BUG();
}
val_size -= ctx->val_bytes;
val += ctx->val_bytes;
Expand All @@ -72,8 +72,8 @@ static int regmap_mmio_gather_write(void *context,

static int regmap_mmio_write(void *context, const void *data, size_t count)
{
if (count < 4)
return -EIO;
BUG_ON(count < 4);

return regmap_mmio_gather_write(context, data, 4, data + 4, count - 4);
}

Expand All @@ -84,8 +84,8 @@ static int regmap_mmio_read(void *context,
struct regmap_mmio_context *ctx = context;
u32 offset;

if (reg_size != 4)
return -EIO;
BUG_ON(reg_size != 4);

if (val_size % ctx->val_bytes)
return -EIO;

Expand All @@ -109,7 +109,7 @@ static int regmap_mmio_read(void *context,
#endif
default:
/* Should be caught by regmap_mmio_check_config */
return -EIO;
BUG();
}
val_size -= ctx->val_bytes;
val += ctx->val_bytes;
Expand Down

0 comments on commit ae5d8af

Please sign in to comment.