Skip to content

Commit

Permalink
[PATCH] remove unneeded SI_TIMER checks
Browse files Browse the repository at this point in the history
This patch removes checks for ->si_code == SI_TIMER from send_signal,
specific_send_sig_info, __group_send_sig_info.

I think posix-timers.c used these functions some time ago, now it sends
signals via send_{,group_}sigqueue, so these hooks are unneeded.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Oleg Nesterov authored and Linus Torvalds committed Oct 31, 2005
1 parent 621d312 commit ae6866c
Showing 1 changed file with 0 additions and 18 deletions.
18 changes: 0 additions & 18 deletions kernel/signal.c
Original file line number Diff line number Diff line change
Expand Up @@ -830,12 +830,6 @@ static int send_signal(int sig, struct siginfo *info, struct task_struct *t,
* and sent by user using something other than kill().
*/
return -EAGAIN;
if (info->si_code == SI_TIMER)
/*
* Set up a return to indicate that we dropped
* the signal.
*/
ret = info->si_sys_private;
}

out_set:
Expand All @@ -856,12 +850,6 @@ specific_send_sig_info(int sig, struct siginfo *info, struct task_struct *t)
BUG();
assert_spin_locked(&t->sighand->siglock);

if (!is_si_special(info) && (info->si_code == SI_TIMER))
/*
* Set up a return to indicate that we dropped the signal.
*/
ret = info->si_sys_private;

/* Short-circuit ignored signals. */
if (sig_ignored(t, sig))
goto out;
Expand Down Expand Up @@ -1048,12 +1036,6 @@ __group_send_sig_info(int sig, struct siginfo *info, struct task_struct *p)
assert_spin_locked(&p->sighand->siglock);
handle_stop_signal(sig, p);

if (!is_si_special(info) && (info->si_code == SI_TIMER))
/*
* Set up a return to indicate that we dropped the signal.
*/
ret = info->si_sys_private;

/* Short-circuit ignored signals. */
if (sig_ignored(p, sig))
return ret;
Expand Down

0 comments on commit ae6866c

Please sign in to comment.