Skip to content

Commit

Permalink
ARM: kprobes: Make str_pc_offset a constant on ARMv7
Browse files Browse the repository at this point in the history
The str_pc_offset value is architecturally defined on ARMv7 onwards so
we can make it a compile time constant. This means on Thumb kernels the
runtime checking code isn't needed, which saves us from having to fix it
to work for Thumb.

Signed-off-by: Jon Medhurst <tixy@yxit.co.uk>
Acked-by: Nicolas Pitre <nicolas.pitre@linaro.org>
  • Loading branch information
Jon Medhurst authored and Tixy committed Jul 13, 2011
1 parent 6c8df33 commit aea4902
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 0 deletions.
4 changes: 4 additions & 0 deletions arch/arm/kernel/kprobes-common.c
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
#include "kprobes.h"


#ifndef find_str_pc_offset

/*
* For STR and STM instructions, an ARM core may choose to use either
* a +8 or a +12 displacement from the current instruction's address.
Expand All @@ -40,6 +42,8 @@ void __init find_str_pc_offset(void)
str_pc_offset = ret;
}

#endif /* !find_str_pc_offset */


void __init arm_kprobe_decode_init(void)
{
Expand Down
14 changes: 14 additions & 0 deletions arch/arm/kernel/kprobes.h
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,21 @@ void __init arm_kprobe_decode_init(void);

extern kprobe_check_cc * const kprobe_condition_checks[16];


#if __LINUX_ARM_ARCH__ >= 7

/* str_pc_offset is architecturally defined from ARMv7 onwards */
#define str_pc_offset 8
#define find_str_pc_offset()

#else /* __LINUX_ARM_ARCH__ < 7 */

/* We need a run-time check to determine str_pc_offset */
extern int str_pc_offset;
void __init find_str_pc_offset(void);

#endif


/*
* Test if load/store instructions writeback the address register.
Expand Down

0 comments on commit aea4902

Please sign in to comment.