Skip to content

Commit

Permalink
[PATCH] readahead: fix initial window size calculation
Browse files Browse the repository at this point in the history
The current current get_init_ra_size is not optimal across different IO
sizes and max_readahead values.  Here is a quick summary of sizes computed
under current design and under the attached patch.  All of these assume 1st
IO at offset 0, or 1st detected sequential IO.

	32k max, 4k request

	old         new
	-----------------
	 8k        8k
	16k       16k
	32k       32k

	128k max, 4k request
	old         new
	-----------------
	32k         16k
	64k         32k
	128k        64k
	128k       128k

	128k max, 32k request
	old         new
	-----------------
	32k         64k    <-----
	64k        128k
	128k       128k

	512k max, 4k request
	old         new
	-----------------
	4k         32k     <----
	16k        64k
	64k       128k
	128k      256k
	512k      512k

Cc: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Steven Pratt <slpratt@austin.ibm.com>
Cc: Ram Pai <linuxram@us.ibm.com>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Steven Pratt authored and Linus Torvalds committed Mar 22, 2006
1 parent a564da3 commit aed75ff
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions mm/readahead.c
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,10 @@ static unsigned long get_init_ra_size(unsigned long size, unsigned long max)
{
unsigned long newsize = roundup_pow_of_two(size);

if (newsize <= max / 64)
newsize = newsize * newsize;
if (newsize <= max / 32)
newsize = newsize * 4;
else if (newsize <= max / 4)
newsize = max / 4;
newsize = newsize * 2;
else
newsize = max;
return newsize;
Expand Down

0 comments on commit aed75ff

Please sign in to comment.