Skip to content

Commit

Permalink
ASoC: tegra+alc5632: move all GPIO setup into probe
Browse files Browse the repository at this point in the history
Now that deferred probe exists, we can parse device tree and request
GPIOs from probe(), rather than deferring this to the DAI link's init().

Signed-off-by: Stephen Warren <swarren@nvidia.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
  • Loading branch information
Stephen Warren authored and Mark Brown committed Jun 3, 2012
1 parent e44fbbd commit aef9a37
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions sound/soc/tegra/tegra_alc5632.c
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* tegra_alc5632.c -- Toshiba AC100(PAZ00) machine ASoC driver
* tegra_alc5632.c -- Toshiba AC100(PAZ00) machine ASoC driver
*
* Copyright (C) 2011 The AC100 Kernel Team <ac100@lists.lauchpad.net>
* Copyright (C) 2012 - NVIDIA, Inc.
Expand Down Expand Up @@ -110,7 +110,6 @@ static int tegra_alc5632_asoc_init(struct snd_soc_pcm_runtime *rtd)
{
struct snd_soc_codec *codec = rtd->codec;
struct snd_soc_dapm_context *dapm = &codec->dapm;
struct device_node *np = codec->card->dev->of_node;
struct tegra_alc5632 *machine = snd_soc_card_get_drvdata(codec->card);

snd_soc_jack_new(codec, "Headset Jack", SND_JACK_HEADSET,
Expand All @@ -119,8 +118,6 @@ static int tegra_alc5632_asoc_init(struct snd_soc_pcm_runtime *rtd)
ARRAY_SIZE(tegra_alc5632_hs_jack_pins),
tegra_alc5632_hs_jack_pins);

machine->gpio_hp_det = of_get_named_gpio(np, "nvidia,hp-det-gpios", 0);

if (gpio_is_valid(machine->gpio_hp_det)) {
tegra_alc5632_hp_jack_gpio.gpio = machine->gpio_hp_det;
snd_soc_jack_add_gpios(&tegra_alc5632_hs_jack,
Expand Down Expand Up @@ -159,6 +156,7 @@ static struct snd_soc_card snd_soc_tegra_alc5632 = {

static __devinit int tegra_alc5632_probe(struct platform_device *pdev)
{
struct device_node *np = pdev->dev.of_node;
struct snd_soc_card *card = &snd_soc_tegra_alc5632;
struct tegra_alc5632 *alc5632;
int ret;
Expand All @@ -181,6 +179,10 @@ static __devinit int tegra_alc5632_probe(struct platform_device *pdev)
goto err;
}

alc5632->gpio_hp_det = of_get_named_gpio(np, "nvidia,hp-det-gpios", 0);
if (alc5632->gpio_hp_det == -ENODEV)
return -EPROBE_DEFER;

ret = snd_soc_of_parse_card_name(card, "nvidia,model");
if (ret)
goto err;
Expand Down

0 comments on commit aef9a37

Please sign in to comment.