Skip to content

Commit

Permalink
drm/radeon/kms: keep HDMI state in separated variable
Browse files Browse the repository at this point in the history
If we want hdmi_offset to be relative to the first block, zero value can
be used also for enabled block.

Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
Tested-by: Christian König <deathsimple@vodafone.de>
Reviewed-by: Christian König <deathsimple@vodafone.de>
Signed-off-by: Dave Airlie <airlied@redhat.com>
  • Loading branch information
Rafał Miłecki authored and Dave Airlie committed May 1, 2012
1 parent 816ce43 commit af0b574
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 7 deletions.
16 changes: 9 additions & 7 deletions drivers/gpu/drm/radeon/r600_hdmi.c
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ int r600_hdmi_buffer_status_changed(struct drm_encoder *encoder)
struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
int status, result;

if (!radeon_encoder->hdmi_offset)
if (!radeon_encoder->hdmi_enabled)
return 0;

status = r600_hdmi_is_audio_buffer_filled(encoder);
Expand All @@ -295,7 +295,7 @@ void r600_hdmi_audio_workaround(struct drm_encoder *encoder)
struct radeon_encoder *radeon_encoder = to_radeon_encoder(encoder);
uint32_t offset = radeon_encoder->hdmi_offset;

if (!offset)
if (!radeon_encoder->hdmi_enabled)
return;

if (!radeon_encoder->hdmi_audio_workaround ||
Expand Down Expand Up @@ -323,7 +323,7 @@ void r600_hdmi_setmode(struct drm_encoder *encoder, struct drm_display_mode *mod
if (ASIC_IS_DCE5(rdev))
return;

if (!offset)
if (!to_radeon_encoder(encoder)->hdmi_enabled)
return;

r600_audio_set_clock(encoder, mode->clock);
Expand Down Expand Up @@ -370,7 +370,7 @@ void r600_hdmi_update_audio_settings(struct drm_encoder *encoder)

uint32_t iec;

if (!offset)
if (!to_radeon_encoder(encoder)->hdmi_enabled)
return;

DRM_DEBUG("%s with %d channels, %d Hz sampling rate, %d bits per sample,\n",
Expand Down Expand Up @@ -463,6 +463,7 @@ static void r600_hdmi_assign_block(struct drm_encoder *encoder)
/* Only 1 routable block */
radeon_encoder->hdmi_offset = R600_HDMI_BLOCK1;
}
radeon_encoder->hdmi_enabled = true;
}

/*
Expand All @@ -478,9 +479,9 @@ void r600_hdmi_enable(struct drm_encoder *encoder)
if (ASIC_IS_DCE5(rdev))
return;

if (!radeon_encoder->hdmi_offset) {
if (!radeon_encoder->hdmi_enabled) {
r600_hdmi_assign_block(encoder);
if (!radeon_encoder->hdmi_offset) {
if (!radeon_encoder->hdmi_enabled) {
dev_warn(rdev->dev, "Could not find HDMI block for "
"0x%x encoder\n", radeon_encoder->encoder_id);
return;
Expand Down Expand Up @@ -538,7 +539,7 @@ void r600_hdmi_disable(struct drm_encoder *encoder)
return;

offset = radeon_encoder->hdmi_offset;
if (!offset) {
if (!radeon_encoder->hdmi_enabled) {
dev_err(rdev->dev, "Disabling not enabled HDMI\n");
return;
}
Expand Down Expand Up @@ -575,5 +576,6 @@ void r600_hdmi_disable(struct drm_encoder *encoder)
}
}

radeon_encoder->hdmi_enabled = false;
radeon_encoder->hdmi_offset = 0;
}
1 change: 1 addition & 0 deletions drivers/gpu/drm/radeon/radeon_mode.h
Original file line number Diff line number Diff line change
Expand Up @@ -384,6 +384,7 @@ struct radeon_encoder {
struct drm_display_mode native_mode;
void *enc_priv;
int audio_polling_active;
bool hdmi_enabled;
int hdmi_offset;
int hdmi_audio_workaround;
int hdmi_buffer_status;
Expand Down

0 comments on commit af0b574

Please sign in to comment.