Skip to content

Commit

Permalink
video: s3c-fb: correct transparency checking in 32bpp
Browse files Browse the repository at this point in the history
32bpp means ARGB 8888 in the driver, therfore the transparency length
and offset should be 8 and 24 respectively. However, the transparency
length and offset were previously 0, which means that the driver supports
RGB 888 without alpha blending when 32bpp is used.

So, the transparency checking in 32bpp is corrected so that the
transparency length and offset are 8 and 24 respectively.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
  • Loading branch information
Jingoo Han authored and Paul Mundt committed May 24, 2011
1 parent 6aa9681 commit af1ce6b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/video/s3c-fb.c
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,7 @@ static int s3c_fb_check_var(struct fb_var_screeninfo *var,
var->blue.length = 5;
break;

case 32:
case 28:
case 25:
var->transp.length = var->bits_per_pixel - 24;
Expand All @@ -310,7 +311,6 @@ static int s3c_fb_check_var(struct fb_var_screeninfo *var,
case 24:
/* our 24bpp is unpacked, so 32bpp */
var->bits_per_pixel = 32;
case 32:
var->red.offset = 16;
var->red.length = 8;
var->green.offset = 8;
Expand Down

0 comments on commit af1ce6b

Please sign in to comment.