Skip to content

Commit

Permalink
bnx2x: Wrong HDR offset in CAM
Browse files Browse the repository at this point in the history
Has a negative side effect when sending MAC update with no content (as done in
the self-test)

Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Eilon Greenstein authored and David S. Miller committed Jan 20, 2009
1 parent b466173 commit af24640
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions drivers/net/bnx2x_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -6144,7 +6144,7 @@ static void bnx2x_set_mac_addr_e1(struct bnx2x *bp, int set)
* multicast 64-127:port0 128-191:port1
*/
config->hdr.length_6b = 2;
config->hdr.offset = port ? 31 : 0;
config->hdr.offset = port ? 32 : 0;
config->hdr.client_id = BP_CL_ID(bp);
config->hdr.reserved1 = 0;

Expand Down Expand Up @@ -8910,7 +8910,10 @@ static int bnx2x_test_intr(struct bnx2x *bp)
return -ENODEV;

config->hdr.length_6b = 0;
config->hdr.offset = 0;
if (CHIP_IS_E1(bp))
config->hdr.offset = (BP_PORT(bp) ? 32 : 0);
else
config->hdr.offset = BP_FUNC(bp);
config->hdr.client_id = BP_CL_ID(bp);
config->hdr.reserved1 = 0;

Expand Down Expand Up @@ -9863,7 +9866,7 @@ static void bnx2x_set_rx_mode(struct net_device *dev)
for (; i < old; i++) {
if (CAM_IS_INVALID(config->
config_table[i])) {
i--; /* already invalidated */
/* already invalidated */
break;
}
/* invalidate */
Expand Down

0 comments on commit af24640

Please sign in to comment.