Skip to content

Commit

Permalink
misannotation in pppol2tp
Browse files Browse the repository at this point in the history
Address of auto variable is not a userland pointer.  A good thing, too,
since if pppol2tp_tunnel_getsockopt() would _really_ get a userland pointer
as argument, it would be an instant roothole...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Al Viro authored and Linus Torvalds committed Jul 26, 2007
1 parent 6aa8b04 commit af3b162
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/net/pppol2tp.c
Original file line number Diff line number Diff line change
Expand Up @@ -2054,7 +2054,7 @@ static int pppol2tp_setsockopt(struct socket *sock, int level, int optname,
*/
static int pppol2tp_tunnel_getsockopt(struct sock *sk,
struct pppol2tp_tunnel *tunnel,
int optname, int __user *val)
int optname, int *val)
{
int err = 0;

Expand All @@ -2077,7 +2077,7 @@ static int pppol2tp_tunnel_getsockopt(struct sock *sk,
*/
static int pppol2tp_session_getsockopt(struct sock *sk,
struct pppol2tp_session *session,
int optname, int __user *val)
int optname, int *val)
{
int err = 0;

Expand Down

0 comments on commit af3b162

Please sign in to comment.