Skip to content

Commit

Permalink
uprobes: Kill the bogus IS_ERR_VALUE(xol_vaddr) check
Browse files Browse the repository at this point in the history
utask->xol_vaddr is either zero or valid, remove the bogus
IS_ERR_VALUE() check in xol_free_insn_slot().

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Anton Arapov <anton@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
  • Loading branch information
Oleg Nesterov committed Feb 8, 2013
1 parent 608e742 commit af4355e
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions kernel/events/uprobes.c
Original file line number Diff line number Diff line change
Expand Up @@ -1223,8 +1223,7 @@ static void xol_free_insn_slot(struct task_struct *tsk)
return;

slot_addr = tsk->utask->xol_vaddr;

if (unlikely(!slot_addr || IS_ERR_VALUE(slot_addr)))
if (unlikely(!slot_addr))
return;

area = tsk->mm->uprobes_state.xol_area;
Expand Down

0 comments on commit af4355e

Please sign in to comment.