Skip to content

Commit

Permalink
[media] tvp5150: signedness bug in tvp5150_selmux()
Browse files Browse the repository at this point in the history
tvp5150_read() returns negative error codes so this needs to be an int
for the error handling to work.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Dan Carpenter authored and Mauro Carvalho Chehab committed Jul 30, 2012
1 parent 79ef87e commit afcc8e8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/media/video/tvp5150.c
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ static inline void tvp5150_selmux(struct v4l2_subdev *sd)
int opmode = 0;
struct tvp5150 *decoder = to_tvp5150(sd);
int input = 0;
unsigned char val;
int val;

if ((decoder->output & TVP5150_BLACK_SCREEN) || !decoder->enable)
input = 8;
Expand Down

0 comments on commit afcc8e8

Please sign in to comment.