Skip to content

Commit

Permalink
net: copy_rtnl_link_stats64() simplification
Browse files Browse the repository at this point in the history
No need to use a temporary struct rtnl_link_stats64 variable,
just copy the source to skb buffer.

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Reviewed-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Eric Dumazet authored and David S. Miller committed Aug 24, 2010
1 parent 0eec32f commit afdcba3
Showing 1 changed file with 1 addition and 30 deletions.
31 changes: 1 addition & 30 deletions net/core/rtnetlink.c
Original file line number Diff line number Diff line change
Expand Up @@ -612,36 +612,7 @@ static void copy_rtnl_link_stats(struct rtnl_link_stats *a,

static void copy_rtnl_link_stats64(void *v, const struct rtnl_link_stats64 *b)
{
struct rtnl_link_stats64 a;

a.rx_packets = b->rx_packets;
a.tx_packets = b->tx_packets;
a.rx_bytes = b->rx_bytes;
a.tx_bytes = b->tx_bytes;
a.rx_errors = b->rx_errors;
a.tx_errors = b->tx_errors;
a.rx_dropped = b->rx_dropped;
a.tx_dropped = b->tx_dropped;

a.multicast = b->multicast;
a.collisions = b->collisions;

a.rx_length_errors = b->rx_length_errors;
a.rx_over_errors = b->rx_over_errors;
a.rx_crc_errors = b->rx_crc_errors;
a.rx_frame_errors = b->rx_frame_errors;
a.rx_fifo_errors = b->rx_fifo_errors;
a.rx_missed_errors = b->rx_missed_errors;

a.tx_aborted_errors = b->tx_aborted_errors;
a.tx_carrier_errors = b->tx_carrier_errors;
a.tx_fifo_errors = b->tx_fifo_errors;
a.tx_heartbeat_errors = b->tx_heartbeat_errors;
a.tx_window_errors = b->tx_window_errors;

a.rx_compressed = b->rx_compressed;
a.tx_compressed = b->tx_compressed;
memcpy(v, &a, sizeof(a));
memcpy(v, b, sizeof(*b));
}

/* All VF info */
Expand Down

0 comments on commit afdcba3

Please sign in to comment.