Skip to content

Commit

Permalink
[PATCH] random: remove SA_SAMPLE_RANDOM from floppy driver
Browse files Browse the repository at this point in the history
The floppy driver is already calling add_disk_randomness as it should, so this
was redundant.

Signed-off-by: Matt Mackall <mpm@selenic.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Matt Mackall authored and Linus Torvalds committed Jun 25, 2006
1 parent 5184973 commit afedfd0
Show file tree
Hide file tree
Showing 11 changed files with 18 additions and 28 deletions.
5 changes: 2 additions & 3 deletions include/asm-alpha/floppy.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,8 @@
#define fd_enable_irq() enable_irq(FLOPPY_IRQ)
#define fd_disable_irq() disable_irq(FLOPPY_IRQ)
#define fd_cacheflush(addr,size) /* nothing */
#define fd_request_irq() request_irq(FLOPPY_IRQ, floppy_interrupt, \
SA_INTERRUPT|SA_SAMPLE_RANDOM, \
"floppy", NULL)
#define fd_request_irq() request_irq(FLOPPY_IRQ, floppy_interrupt,\
SA_INTERRUPT, "floppy", NULL)
#define fd_free_irq() free_irq(FLOPPY_IRQ, NULL);

#ifdef CONFIG_PCI
Expand Down
2 changes: 1 addition & 1 deletion include/asm-arm/floppy.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@

#define fd_inb(port) inb((port))
#define fd_request_irq() request_irq(IRQ_FLOPPYDISK,floppy_interrupt,\
SA_INTERRUPT|SA_SAMPLE_RANDOM,"floppy",NULL)
SA_INTERRUPT,"floppy",NULL)
#define fd_free_irq() free_irq(IRQ_FLOPPYDISK,NULL)
#define fd_disable_irq() disable_irq(IRQ_FLOPPYDISK)
#define fd_enable_irq() enable_irq(IRQ_FLOPPYDISK)
Expand Down
2 changes: 1 addition & 1 deletion include/asm-arm26/floppy.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

#define fd_inb(port) inb((port))
#define fd_request_irq() request_irq(IRQ_FLOPPYDISK,floppy_interrupt,\
SA_INTERRUPT|SA_SAMPLE_RANDOM,"floppy",NULL)
SA_INTERRUPT,"floppy",NULL)
#define fd_free_irq() free_irq(IRQ_FLOPPYDISK,NULL)
#define fd_disable_irq() disable_irq(IRQ_FLOPPYDISK)
#define fd_enable_irq() enable_irq(IRQ_FLOPPYDISK)
Expand Down
5 changes: 2 additions & 3 deletions include/asm-i386/floppy.h
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,8 @@ static int fd_request_irq(void)
return request_irq(FLOPPY_IRQ, floppy_hardint,SA_INTERRUPT,
"floppy", NULL);
else
return request_irq(FLOPPY_IRQ, floppy_interrupt,
SA_INTERRUPT|SA_SAMPLE_RANDOM,
"floppy", NULL);
return request_irq(FLOPPY_IRQ, floppy_interrupt, SA_INTERRUPT,
"floppy", NULL);

}

Expand Down
2 changes: 1 addition & 1 deletion include/asm-mips/mach-generic/floppy.h
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ static inline void fd_disable_irq(void)
static inline int fd_request_irq(void)
{
return request_irq(FLOPPY_IRQ, floppy_interrupt,
SA_INTERRUPT | SA_SAMPLE_RANDOM, "floppy", NULL);
SA_INTERRUPT, "floppy", NULL);
}

static inline void fd_free_irq(void)
Expand Down
2 changes: 1 addition & 1 deletion include/asm-mips/mach-jazz/floppy.h
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ static inline void fd_disable_irq(void)
static inline int fd_request_irq(void)
{
return request_irq(FLOPPY_IRQ, floppy_interrupt,
SA_INTERRUPT | SA_SAMPLE_RANDOM, "floppy", NULL);
SA_INTERRUPT, "floppy", NULL);
}

static inline void fd_free_irq(void)
Expand Down
6 changes: 2 additions & 4 deletions include/asm-parisc/floppy.h
Original file line number Diff line number Diff line change
Expand Up @@ -159,10 +159,8 @@ static int fd_request_irq(void)
return request_irq(FLOPPY_IRQ, floppy_hardint,SA_INTERRUPT,
"floppy", NULL);
else
return request_irq(FLOPPY_IRQ, floppy_interrupt,
SA_INTERRUPT|SA_SAMPLE_RANDOM,
"floppy", NULL);

return request_irq(FLOPPY_IRQ, floppy_interrupt, SA_INTERRUPT,
"floppy", NULL);
}

static unsigned long dma_mem_alloc(unsigned long size)
Expand Down
3 changes: 1 addition & 2 deletions include/asm-powerpc/floppy.h
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@
#define fd_disable_irq() disable_irq(FLOPPY_IRQ)
#define fd_cacheflush(addr,size) /* nothing */
#define fd_request_irq() request_irq(FLOPPY_IRQ, floppy_interrupt, \
SA_INTERRUPT|SA_SAMPLE_RANDOM, \
"floppy", NULL)
SA_INTERRUPT, "floppy", NULL)
#define fd_free_irq() free_irq(FLOPPY_IRQ, NULL);

#ifdef CONFIG_PCI
Expand Down
6 changes: 2 additions & 4 deletions include/asm-ppc/floppy.h
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,8 @@ static int fd_request_irq(void)
return request_irq(FLOPPY_IRQ, floppy_hardint,SA_INTERRUPT,
"floppy", NULL);
else
return request_irq(FLOPPY_IRQ, floppy_interrupt,
SA_INTERRUPT|SA_SAMPLE_RANDOM,
"floppy", NULL);

return request_irq(FLOPPY_IRQ, floppy_interrupt, SA_INTERRUPT,
"floppy", NULL);
}

static int vdma_dma_setup(char *addr, unsigned long size, int mode, int io)
Expand Down
7 changes: 3 additions & 4 deletions include/asm-sh/floppy.h
Original file line number Diff line number Diff line change
Expand Up @@ -147,11 +147,10 @@ static int fd_request_irq(void)
{
if(can_use_virtual_dma)
return request_irq(FLOPPY_IRQ, floppy_hardint,SA_INTERRUPT,
"floppy", NULL);
"floppy", NULL);
else
return request_irq(FLOPPY_IRQ, floppy_interrupt,
SA_INTERRUPT|SA_SAMPLE_RANDOM,
"floppy", NULL);
return request_irq(FLOPPY_IRQ, floppy_interrupt, SA_INTERRUPT,
"floppy", NULL);

}

Expand Down
6 changes: 2 additions & 4 deletions include/asm-x86_64/floppy.h
Original file line number Diff line number Diff line change
Expand Up @@ -147,10 +147,8 @@ static int fd_request_irq(void)
return request_irq(FLOPPY_IRQ, floppy_hardint,SA_INTERRUPT,
"floppy", NULL);
else
return request_irq(FLOPPY_IRQ, floppy_interrupt,
SA_INTERRUPT|SA_SAMPLE_RANDOM,
"floppy", NULL);

return request_irq(FLOPPY_IRQ, floppy_interrupt, SA_INTERRUPT,
"floppy", NULL);
}

static unsigned long dma_mem_alloc(unsigned long size)
Expand Down

0 comments on commit afedfd0

Please sign in to comment.