Skip to content

Commit

Permalink
staging/easycap: prefer printk over SAY in module entry functions
Browse files Browse the repository at this point in the history
Use INFO level when registering driver and ERR for error.
Drop messages from oneliner exit function

Cc: Mike Thomas <rmthomas@sciolus.org>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Tomas Winkler authored and Greg Kroah-Hartman committed Feb 9, 2011
1 parent ee99aa4 commit aff512c
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions drivers/staging/easycap/easycap_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -4829,33 +4829,27 @@ static int __init easycap_module_init(void)
{
int k, rc;

SAY("========easycap=======\n");
printk(KERN_INFO "Easycap version: "EASYCAP_DRIVER_VERSION "\n");

JOT(4, "begins. %i=debug %i=bars %i=gain\n",
easycap_debug, easycap_bars, easycap_gain);
SAY("version: " EASYCAP_DRIVER_VERSION "\n");

mutex_init(&mutex_dongle);
for (k = 0; k < DONGLE_MANY; k++) {
easycapdc60_dongle[k].peasycap = NULL;
mutex_init(&easycapdc60_dongle[k].mutex_video);
mutex_init(&easycapdc60_dongle[k].mutex_audio);
}
JOT(4, "registering driver easycap\n");
rc = usb_register(&easycap_usb_driver);
if (rc)
SAY("ERROR: usb_register returned %i\n", rc);
printk(KERN_ERR "Easycap: usb_register failed rc=%d\n", rc);

JOT(4, "ends\n");
return rc;
}
/*****************************************************************************/
static void __exit easycap_module_exit(void)
{
JOT(4, "begins\n");

usb_deregister(&easycap_usb_driver);

JOT(4, "ends\n");
}
/*****************************************************************************/

Expand Down

0 comments on commit aff512c

Please sign in to comment.