Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 256322
b: refs/heads/master
c: ecae42d
h: refs/heads/master
v: v3
  • Loading branch information
Geoff Levand authored and David S. Miller committed Jul 14, 2011
1 parent 09ab05d commit aff6c5f
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 15 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 6383c0b35b48bfbd0fc8c6fe126a6603c5a9a4b3
refs/heads/master: ecae42d37045ec71831d0e0e493e00b0e0732edd
21 changes: 8 additions & 13 deletions trunk/drivers/net/ps3_gelic_net.c
Original file line number Diff line number Diff line change
Expand Up @@ -993,10 +993,6 @@ static int gelic_card_decode_one_descr(struct gelic_card *card)
int dmac_chain_ended;

status = gelic_descr_get_status(descr);
/* is this descriptor terminated with next_descr == NULL? */
dmac_chain_ended =
be32_to_cpu(descr->dmac_cmd_status) &
GELIC_DESCR_RX_DMA_CHAIN_END;

if (status == GELIC_DESCR_DMA_CARDOWNED)
return 0;
Expand Down Expand Up @@ -1059,6 +1055,11 @@ static int gelic_card_decode_one_descr(struct gelic_card *card)
/* ok, we've got a packet in descr */
gelic_net_pass_skb_up(descr, card, netdev);
refill:

/* is the current descriptor terminated with next_descr == NULL? */
dmac_chain_ended =
be32_to_cpu(descr->dmac_cmd_status) &
GELIC_DESCR_RX_DMA_CHAIN_END;
/*
* So that always DMAC can see the end
* of the descriptor chain to avoid
Expand Down Expand Up @@ -1087,10 +1088,9 @@ static int gelic_card_decode_one_descr(struct gelic_card *card)
* If dmac chain was met, DMAC stopped.
* thus re-enable it
*/
if (dmac_chain_ended) {
card->rx_dma_restart_required = 1;
dev_dbg(ctodev(card), "reenable rx dma scheduled\n");
}

if (dmac_chain_ended)
gelic_card_enable_rxdmac(card);

return 1;
}
Expand Down Expand Up @@ -1156,11 +1156,6 @@ static irqreturn_t gelic_card_interrupt(int irq, void *ptr)

status &= card->irq_mask;

if (card->rx_dma_restart_required) {
card->rx_dma_restart_required = 0;
gelic_card_enable_rxdmac(card);
}

if (status & GELIC_CARD_RXINT) {
gelic_card_rx_irq_off(card);
napi_schedule(&card->napi);
Expand Down
1 change: 0 additions & 1 deletion trunk/drivers/net/ps3_gelic_net.h
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,6 @@ struct gelic_card {

struct gelic_descr_chain tx_chain;
struct gelic_descr_chain rx_chain;
int rx_dma_restart_required;
/*
* tx_lock guards tx descriptor list and
* tx_dma_progress.
Expand Down

0 comments on commit aff6c5f

Please sign in to comment.