Skip to content

Commit

Permalink
[PATCH] remove ACPI S4bios support
Browse files Browse the repository at this point in the history
Remove S4BIOS support.  It is pretty useless, and only ever worked for _me_
once.  (I do not think anyone else ever tried it).  It was in feature-removal
for a long time, and it should have been removed before.

Signed-off-by: Pavel Machek <pavel@suse.cz>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Cc: "Brown, Len" <len.brown@intel.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Pavel Machek authored and Linus Torvalds committed Sep 10, 2005
1 parent c2d08da commit b01d868
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 27 deletions.
8 changes: 0 additions & 8 deletions Documentation/feature-removal-schedule.txt
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,6 @@ Who: Greg Kroah-Hartman <greg@kroah.com>

---------------------------

What: ACPI S4bios support
When: May 2005
Why: Noone uses it, and it probably does not work, anyway. swsusp is
faster, more reliable, and people are actually using it.
Who: Pavel Machek <pavel@suse.cz>

---------------------------

What: io_remap_page_range() (macro or function)
When: September 2005
Why: Replaced by io_remap_pfn_range() which allows more memory space
Expand Down
6 changes: 0 additions & 6 deletions arch/i386/kernel/acpi/wakeup.S
Original file line number Diff line number Diff line change
Expand Up @@ -304,12 +304,6 @@ ret_point:
call restore_processor_state
ret

ENTRY(do_suspend_lowlevel_s4bios)
call save_processor_state
call save_registers
call acpi_enter_sleep_state_s4bios
ret

ALIGN
# saved registers
saved_gdt: .long 0,0
Expand Down
8 changes: 0 additions & 8 deletions drivers/acpi/sleep/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ u8 sleep_states[ACPI_S_STATE_COUNT];

static struct pm_ops acpi_pm_ops;

extern void do_suspend_lowlevel_s4bios(void);
extern void do_suspend_lowlevel(void);

static u32 acpi_suspend_states[] = {
Expand Down Expand Up @@ -98,8 +97,6 @@ static int acpi_pm_enter(suspend_state_t pm_state)
case PM_SUSPEND_DISK:
if (acpi_pm_ops.pm_disk_mode == PM_DISK_PLATFORM)
status = acpi_enter_sleep_state(acpi_state);
else
do_suspend_lowlevel_s4bios();
break;
case PM_SUSPEND_MAX:
acpi_power_off();
Expand Down Expand Up @@ -206,11 +203,6 @@ static int __init acpi_sleep_init(void)
printk(" S%d", i);
}
if (i == ACPI_STATE_S4) {
if (acpi_gbl_FACS->S4bios_f) {
sleep_states[i] = 1;
printk(" S4bios");
acpi_pm_ops.pm_disk_mode = PM_DISK_FIRMWARE;
}
if (sleep_states[i])
acpi_pm_ops.pm_disk_mode = PM_DISK_PLATFORM;
}
Expand Down
4 changes: 1 addition & 3 deletions drivers/acpi/sleep/poweroff.c
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,7 @@ int acpi_sleep_prepare(u32 acpi_state)
{
#ifdef CONFIG_ACPI_SLEEP
/* do we have a wakeup address for S2 and S3? */
/* Here, we support only S4BIOS, those we set the wakeup address */
/* S4OS is only supported for now via swsusp.. */
if (acpi_state == ACPI_STATE_S3 || acpi_state == ACPI_STATE_S4) {
if (acpi_state == ACPI_STATE_S3) {
if (!acpi_wakeup_address) {
return -EFAULT;
}
Expand Down
2 changes: 0 additions & 2 deletions drivers/acpi/sleep/proc.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ static int acpi_system_sleep_seq_show(struct seq_file *seq, void *offset)
for (i = 0; i <= ACPI_STATE_S5; i++) {
if (sleep_states[i]) {
seq_printf(seq, "S%d ", i);
if (i == ACPI_STATE_S4 && acpi_gbl_FACS->S4bios_f)
seq_printf(seq, "S4bios ");
}
}

Expand Down

0 comments on commit b01d868

Please sign in to comment.