Skip to content

Commit

Permalink
Staging: comedi: fix brace and printk coding style issue in serial2002.c
Browse files Browse the repository at this point in the history
This is a patch to the serial2002.c file that fixes up a brace and printk  warning found by the checkpatch.pl tool

Signed-off-by: Ravishankar <ravishankarkm32@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Ravishankar authored and Greg Kroah-Hartman committed Jul 8, 2011
1 parent cbecb8b commit b041267
Showing 1 changed file with 6 additions and 9 deletions.
15 changes: 6 additions & 9 deletions drivers/staging/comedi/drivers/serial2002.c
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ Status: in development
#include <linux/sched.h>
#include <linux/slab.h>

#include <asm/termios.h>
#include <linux/termios.h>
#include <asm/ioctls.h>
#include <linux/serial.h>
#include <linux/poll.h>
Expand Down Expand Up @@ -192,9 +192,8 @@ static int tty_read(struct file *f, int timeout)
elapsed =
(1000000 * (now.tv_sec - start.tv_sec) +
now.tv_usec - start.tv_usec);
if (elapsed > timeout) {
if (elapsed > timeout)
break;
}
set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(((timeout -
elapsed) * HZ) / 10000);
Expand All @@ -204,9 +203,8 @@ static int tty_read(struct file *f, int timeout)
unsigned char ch;

f->f_pos = 0;
if (f->f_op->read(f, &ch, 1, &f->f_pos) == 1) {
if (f->f_op->read(f, &ch, 1, &f->f_pos) == 1)
result = ch;
}
}
} else {
/* Device does not support poll, busy wait */
Expand All @@ -215,9 +213,8 @@ static int tty_read(struct file *f, int timeout)
unsigned char ch;

retries++;
if (retries >= timeout) {
if (retries >= timeout)
break;
}

f->f_pos = 0;
if (f->f_op->read(f, &ch, 1, &f->f_pos) == 1) {
Expand Down Expand Up @@ -329,7 +326,7 @@ static struct serial_data serial_read(struct file *f, int timeout)

length++;
if (data < 0) {
printk("serial2002 error\n");
printk(KERN_ERR "serial2002 error\n");
break;
} else if (data & 0x80) {
result.value = (result.value << 7) | (data & 0x7f);
Expand Down Expand Up @@ -402,7 +399,7 @@ static int serial_2002_open(struct comedi_device *dev)
devpriv->tty = filp_open(port, O_RDWR, 0);
if (IS_ERR(devpriv->tty)) {
result = (int)PTR_ERR(devpriv->tty);
printk("serial_2002: file open error = %d\n", result);
printk(KERN_ERR "serial_2002: file open error = %d\n", result);
} else {
struct config_t {

Expand Down

0 comments on commit b041267

Please sign in to comment.