Skip to content

Commit

Permalink
PNP: remove redundant pnp_can_configure() check
Browse files Browse the repository at this point in the history
pnp_assign_resources() is static and the only caller checks
pnp_can_configure() before calling it, so no need to do it
again.

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Acked-by: Rene Herman <rene.herman@gmail.com>
Signed-off-by: Len Brown <len.brown@intel.com>
  • Loading branch information
Bjorn Helgaas authored and Andi Kleen committed Jul 16, 2008
1 parent 6e906f0 commit b08395e
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/pnp/manager.c
Original file line number Diff line number Diff line change
Expand Up @@ -231,9 +231,6 @@ static int pnp_assign_resources(struct pnp_dev *dev, int depnum)
struct pnp_dma *dma;
int nport = 0, nmem = 0, nirq = 0, ndma = 0;

if (!pnp_can_configure(dev))
return -ENODEV;

dbg_pnp_show_resources(dev, "before pnp_assign_resources");
mutex_lock(&pnp_res_mutex);
pnp_clean_resource_table(dev);
Expand Down

0 comments on commit b08395e

Please sign in to comment.