Skip to content

Commit

Permalink
[ARM] 4077/1: iop13xx: fix __io() macro
Browse files Browse the repository at this point in the history
Since iop13xx defines the PCI I/O spaces with physical resource addresses
the __io macro needs to perform the physical to virtual conversion.  I
incorrectly assumed that this would be handled by ioremap, but drivers
(like e1000) directly dereference the address returned from __io.

Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
  • Loading branch information
Dan Williams authored and Russell King committed Dec 30, 2006
1 parent 4cc2f7a commit b0b1d60
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 1 deletion.
19 changes: 19 additions & 0 deletions arch/arm/mach-iop13xx/io.c
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,25 @@
#include <asm/hardware.h>
#include <asm/io.h>

void * __iomem __iop13xx_io(unsigned long io_addr)
{
void __iomem * io_virt;

switch (io_addr) {
case IOP13XX_PCIE_LOWER_IO_PA ... IOP13XX_PCIE_UPPER_IO_PA:
io_virt = (void *) IOP13XX_PCIE_IO_PHYS_TO_VIRT(io_addr);
break;
case IOP13XX_PCIX_LOWER_IO_PA ... IOP13XX_PCIX_UPPER_IO_PA:
io_virt = (void *) IOP13XX_PCIX_IO_PHYS_TO_VIRT(io_addr);
break;
default:
BUG();
}

return io_virt;
}
EXPORT_SYMBOL(__iop13xx_io);

void * __iomem __iop13xx_ioremap(unsigned long cookie, size_t size,
unsigned long flags)
{
Expand Down
3 changes: 2 additions & 1 deletion include/asm-arm/arch-iop13xx/io.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,11 @@

#define IO_SPACE_LIMIT 0xffffffff

#define __io(a) (a)
#define __io(a) __iop13xx_io(a)
#define __mem_pci(a) (a)
#define __mem_isa(a) (a)

extern void __iomem * __iop13xx_io(unsigned long io_addr);
extern void __iomem * __ioremap(unsigned long, size_t, unsigned long);
extern void __iomem *__iop13xx_ioremap(unsigned long cookie, size_t size,
unsigned long flags);
Expand Down

0 comments on commit b0b1d60

Please sign in to comment.