Skip to content

Commit

Permalink
cgroup: build list of all cgroups under a given cgroupfs_root
Browse files Browse the repository at this point in the history
Build a list of all cgroups anchored at cgroupfs_root->allcg_list and
going through cgroup->allcg_node.  The list is protected by
cgroup_mutex and will be used to improve cgroup file handling.

Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: Li Zefan <lizf@cn.fujitsu.com>
  • Loading branch information
Tejun Heo committed Apr 1, 2012
1 parent ff4c8d5 commit b0ca5a8
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
2 changes: 2 additions & 0 deletions include/linux/cgroup.h
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,8 @@ struct cgroup {
*/
struct list_head css_sets;

struct list_head allcg_node; /* cgroupfs_root->allcg_list */

/*
* Linked list running through all cgroups that can
* potentially be reaped by the release agent. Protected by
Expand Down
10 changes: 10 additions & 0 deletions kernel/cgroup.c
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,9 @@ struct cgroupfs_root {
/* A list running through the active hierarchies */
struct list_head root_list;

/* All cgroups on this root, cgroup_mutex protected */
struct list_head allcg_list;

/* Hierarchy-specific flags */
unsigned long flags;

Expand Down Expand Up @@ -1350,11 +1353,14 @@ static void init_cgroup_housekeeping(struct cgroup *cgrp)
static void init_cgroup_root(struct cgroupfs_root *root)
{
struct cgroup *cgrp = &root->top_cgroup;

INIT_LIST_HEAD(&root->subsys_list);
INIT_LIST_HEAD(&root->root_list);
INIT_LIST_HEAD(&root->allcg_list);
root->number_of_cgroups = 1;
cgrp->root = root;
cgrp->top_cgroup = cgrp;
list_add_tail(&cgrp->allcg_node, &root->allcg_list);
init_cgroup_housekeeping(cgrp);
}

Expand Down Expand Up @@ -3790,6 +3796,8 @@ static long cgroup_create(struct cgroup *parent, struct dentry *dentry,
/* The cgroup directory was pre-locked for us */
BUG_ON(!mutex_is_locked(&cgrp->dentry->d_inode->i_mutex));

list_add_tail(&cgrp->allcg_node, &root->allcg_list);

err = cgroup_populate_dir(cgrp);
/* If err < 0, we have a half-filled directory - oh well ;) */

Expand Down Expand Up @@ -3998,6 +4006,8 @@ static int cgroup_rmdir(struct inode *unused_dir, struct dentry *dentry)
list_del_init(&cgrp->sibling);
cgroup_unlock_hierarchy(cgrp->root);

list_del_init(&cgrp->allcg_node);

d = dget(cgrp->dentry);

cgroup_d_remove_dir(d);
Expand Down

0 comments on commit b0ca5a8

Please sign in to comment.