Skip to content

Commit

Permalink
ARM: prima2: fix __init section for cpu hotplug
Browse files Browse the repository at this point in the history
The code in arch/arm/mach-prima2/headsmp.S is used for
both boot time initialization and for cpu hotplug,
so it must not be discarded after the initial boot
is complete. This replaces the __INIT annotation
with __CPUINIT, and marks the sirfsoc_cpu_die as
__ref to annotate that it correctly uses the sections.

Without this patch, building prima2_defconfig results in:

WARNING: arch/arm/mach-prima2/built-in.o(.cpuinit.text+0x130): Section mismatch in reference from the function sirfsoc_boot_secondary() to the function .init.text:sirfsoc_secondary_startup()
The function __cpuinit sirfsoc_boot_secondary() references
a function __init sirfsoc_secondary_startup().
If sirfsoc_secondary_startup is only used by sirfsoc_boot_secondary then
annotate sirfsoc_secondary_startup with a matching annotation.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Barry Song <baohua.song@csr.com>
  • Loading branch information
Arnd Bergmann committed Feb 14, 2013
1 parent 1c75c42 commit b0db321
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion arch/arm/mach-prima2/headsmp.S
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
#include <linux/linkage.h>
#include <linux/init.h>

__INIT
__CPUINIT

/*
* Cold boot and hardware reset show different behaviour,
* system will be always panic if we warm-reset the board
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/mach-prima2/hotplug.c
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ static inline void platform_do_lowpower(unsigned int cpu)
*
* Called with IRQs disabled
*/
void sirfsoc_cpu_die(unsigned int cpu)
void __ref sirfsoc_cpu_die(unsigned int cpu)
{
platform_do_lowpower(cpu);
}

0 comments on commit b0db321

Please sign in to comment.