Skip to content

Commit

Permalink
libata-transport.c: local functions should not be exposed globally
Browse files Browse the repository at this point in the history
Functions not referenced outside of a source file should be marked
static to prevent it from being exposed globally.

This quiets the sparse warnings:

warning: symbol 'ata_is_port' was not declared. Should it be static?
warning: symbol 'ata_is_link' was not declared. Should it be static?
warning: symbol 'ata_is_ata_dev' was not declared. Should it be static?

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
  • Loading branch information
H Hartley Sweeten authored and Jeff Garzik committed Jul 25, 2012
1 parent 3a8b788 commit b0e73af
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/ata/libata-transport.c
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ static void ata_tport_release(struct device *dev)
* Returns:
* %1 if the device represents a ATA Port, %0 else
*/
int ata_is_port(const struct device *dev)
static int ata_is_port(const struct device *dev)
{
return dev->release == ata_tport_release;
}
Expand Down Expand Up @@ -355,7 +355,7 @@ static void ata_tlink_release(struct device *dev)
* Returns:
* %1 if the device represents a ATA link, %0 else
*/
int ata_is_link(const struct device *dev)
static int ata_is_link(const struct device *dev)
{
return dev->release == ata_tlink_release;
}
Expand Down Expand Up @@ -572,7 +572,7 @@ static void ata_tdev_release(struct device *dev)
* Returns:
* %1 if the device represents a ATA device, %0 else
*/
int ata_is_ata_dev(const struct device *dev)
static int ata_is_ata_dev(const struct device *dev)
{
return dev->release == ata_tdev_release;
}
Expand Down

0 comments on commit b0e73af

Please sign in to comment.