Skip to content

Commit

Permalink
leds: move h1940-leds's probe function to .devinit.text
Browse files Browse the repository at this point in the history
A pointer to h1940leds_probe is passed to the core via
platform_driver_register and so the function must not disappear when the
.init sections are discarded.  Otherwise (if also having HOTPLUG=y)
unbinding and binding a device to the driver via sysfs will result in an
oops as does a device being registered late.

An alternative to this patch is using platform_driver_probe instead of
platform_driver_register plus removing the pointer to the probe function
from the struct platform_driver.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Richard Purdie <rpurdie@linux.intel.com>
  • Loading branch information
Uwe Kleine-König authored and Richard Purdie committed Apr 6, 2009
1 parent bfb2cc4 commit b0edba7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/leds/leds-h1940.c
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ static struct led_classdev h1940_blueled = {
.default_trigger = "h1940-bluetooth",
};

static int __init h1940leds_probe(struct platform_device *pdev)
static int __devinit h1940leds_probe(struct platform_device *pdev)
{
int ret;

Expand Down

0 comments on commit b0edba7

Please sign in to comment.